Skip to content

Rework vhost memory region updates

Dr. David Alan Gilbert (git) qemu-devel 7 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v7 Latest7 patches 1 replyIn review
  2. v67 patches 4 repliesSuperseded
  3. v57 patches 19 repliesSuperseded
Earlier versions · 4
VersionPostedPatchesRepliesStatus
v46 patches17 repliesSuperseded
v38 patches6 repliesSuperseded
v2 RFC8 patches1 replySuperseded
v1 RFC7 patches17 repliesSuperseded

Patches in v7 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/7vhost: Build temporary section list and deref after commithw/virtio/vhost.c include/hw/virtio/vhost.h+49 -260 replies
2/7vhost: Simplify ring verification checkshw/virtio/vhost.c+40 -350 replies
3/7vhost: Merge sections added to temporary listhw/virtio/trace-events hw/virtio/vhost.c+71 -90 replies
4/7vhost: Regenerate region list from changed sections listhw/virtio/trace-events hw/virtio/vhost.c+36 -41 reply
5/7vhost: Clean out old vhost_set_memory and friendshw/virtio/vhost.c include/hw/virtio/vhost.h+0 -2540 replies
6/7vhost: Merge and delete unused callbackshw/virtio/vhost.c+5 -280 replies
7/7vhost: Move log_dirty checkhw/virtio/trace-events hw/virtio/vhost.c+14 -70 replies

Reviews trailers per patch

5 of 7 patches have a Reviewed-by or Acked-by.

PatchIgor Mammedov
1/7R-b
2/7R-b
3/7R-b
4/7R-b
5/7
6/7R-b
7/7

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v7 thread

Cover letter [Qemu-devel] [PATCH v7 0/7] Rework vhost memory region updates

From: "Dr. David Alan Gilbert" <[email protected]>

Hi,
This patch set reworks the way the vhost code handles changes in
physical address space layout that came from a discussion with Igor.

Its intention is to simplify a lot of the update code, and to make it easier for the postcopy+shared code to do the hugepage alignments that are needed.

Instead of inserting/removing each section during the add/del callbacks of the listener, we start afresh and build a list from the add and nop callbacks, then at the end compare the list we've built with the exisiting list.

v7
Avoid calling memcmp(NULL,NULL,0) in region list compare

v6
Tidy ups from Igor
The biggest change is moving the 'Move log_dirty check' to be the last patch in the set.

Dr. David Alan Gilbert (7):
vhost: Build temporary section list and deref after commit
vhost: Simplify ring verification checks
vhost: Merge sections added to temporary list
vhost: Regenerate region list from changed sections list
vhost: Clean out old vhost_set_memory and friends
vhost: Merge and delete unused callbacks
vhost: Move log_dirty check

 hw/virtio/trace-events    |   6 +
 hw/virtio/vhost.c         | 497 ++++++++++++++++------------------------------
 include/hw/virtio/vhost.h |   5 +-
 3 files changed, 180 insertions(+), 328 deletions(-)
Signature · 1 line
2.14.3