Skip to content

s390x/tcg: CCW hotplug, facilities, instructions

David Hildenbrand qemu-devel 3 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest14 patches 7 repliesIn review
  2. v25 patches 8 repliesSuperseded
  3. v15 patches 24 repliesSuperseded

Changes in v3 from the cover letter

- squashed the ASI/ASGI and ALSI/ALSGI patches.
- Both now emulate old behavior.
- "s390x/tcg: implement Interlocked-Access Facility 2"
- now also emulates old behavior.
- "s390x/tcg: implement SET CLOCK PROGRAMMABLE FIELD"
- now forwards r1 into the helper.
- "s390x/tcg: implement extract-CPU-time facility"
- takes care of user-only
- "s390x: change the QEMU cpu model to a stripped down z12"
- const -> static const for two feature bitmaps

Patches in v3 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/14s390x/kvm: factor out build_channel_report_mcic() into cpu.htarget/s390x/cpu.h target/s390x/kvm.c+25 -231 reply
2/14s390x/tcg: fix and cleanup mcck injectiontarget/s390x/excp_helper.c target/s390x/internal.h+9 -90 replies
3/14s390x/tcg: implement SET CLOCK PROGRAMMABLE FIELDtarget/s390x/helper.h target/s390x/insn-data.def target/s390x/misc_helper.c +1 more+21 -01 reply
4/14s390x/tcg: indicate value of TODPR in STCKEtarget/s390x/translate.c+5 -00 replies
5/14s390x/tcg: wire up STORE CHANNEL REPORT WORDtarget/s390x/helper.h target/s390x/insn-data.def target/s390x/misc_helper.c +1 more+19 -00 replies
6/14s390x/tcg: ASI/ASGI/ALSI/ALSGI are atomic with Interlocked-acccess facility 1target/s390x/insn-data.def target/s390x/translate.c+25 -40 replies
7/14s390x/tcg: implement Interlocked-Access Facility 2target/s390x/cpu_models.c target/s390x/insn-data.def target/s390x/translate.c+70 -60 replies
8/14s390x/tcg: wire up SET ADDRESS LIMITtarget/s390x/helper.h target/s390x/insn-data.def target/s390x/misc_helper.c +1 more+18 -00 replies
9/14s390x/tcg: wire up SET CHANNEL MONITORtarget/s390x/helper.h target/s390x/insn-data.def target/s390x/misc_helper.c +1 more+18 -00 replies
10/14s390x/tcg: Implement STORE CHANNEL PATH STATUStarget/s390x/insn-data.def target/s390x/translate.c+8 -00 replies
11/14s390x/tcg: Implement SIGNAL ADAPTER instructiontarget/s390x/insn-data.def target/s390x/translate.c+9 -00 replies
12/14s390x/tcg: implement extract-CPU-time facilitytarget/s390x/cpu_models.c target/s390x/helper.h target/s390x/insn-data.def +2 more+50 -70 replies
13/14s390x/tcg: we already implement the Set-Program-Parameter facilitytarget/s390x/cpu_models.c+3 -20 replies
14/14s390x: change the QEMU cpu model to a stripped down z12hw/s390x/s390-virtio-ccw.c target/s390x/cpu.h target/s390x/cpu_models.c +2 more+140 -5913 replies

Reviews trailers per patch

9 of 14 patches have a Reviewed-by or Acked-by.

PatchThomas HuthRichard Henderson
1/14R-b
2/14
3/14R-b R-b
4/14R-b
5/14R-b R-b
6/14
7/14
8/14R-b
9/14R-b
10/14R-b
11/14R-b
12/14
13/14R-b
14/14

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v3 thread

Cover letter [Qemu-devel] [PATCH v3 for-2.12 00/14] s390x/tcg: CCW hotplug, facilities, instructions

Both series in one piece as (most probably) most reviewing is done.

Wire up some io instructions and implement new facilitites. Make sure to take care of MTTCG when it comes to atomic operations. Make CCW hotplug work.

As we are now able to install/boot a Fedora 26/27 as well as an upstream kernel compiled for z12, let's bump up the QEMU cpu model to a very stripped down version of a z12 (with missing base features). Take care of backwards compatibility (as we defined the QEMU model as migration-safe).

Avilable at: https://github.com/davidhildenbrand/qemu.git s390x-queue

v2 -> v3:
- squashed the ASI/ASGI and ALSI/ALSGI patches.
- Both now emulate old behavior.
- "s390x/tcg: implement Interlocked-Access Facility 2"
- now also emulates old behavior.
- "s390x/tcg: implement SET CLOCK PROGRAMMABLE FIELD"
- now forwards r1 into the helper.
- "s390x/tcg: implement extract-CPU-time facility"
- takes care of user-only
- "s390x: change the QEMU cpu model to a stripped down z12"
- const -> static const for two feature bitmaps

David Hildenbrand (14):
s390x/kvm: factor out build_channel_report_mcic() into cpu.h s390x/tcg: fix and cleanup mcck injection
s390x/tcg: implement SET CLOCK PROGRAMMABLE FIELD s390x/tcg: indicate value of TODPR in STCKE
s390x/tcg: wire up STORE CHANNEL REPORT WORD
s390x/tcg: ASI/ASGI/ALSI/ALSGI are atomic with Interlocked-acccess
facility 1
s390x/tcg: implement Interlocked-Access Facility 2 s390x/tcg: wire up SET ADDRESS LIMIT
s390x/tcg: wire up SET CHANNEL MONITOR
s390x/tcg: Implement STORE CHANNEL PATH STATUS s390x/tcg: Implement SIGNAL ADAPTER instruction s390x/tcg: implement extract-CPU-time facility s390x/tcg: we already implement the Set-Program-Parameter facility
s390x: change the QEMU cpu model to a stripped down z12

 hw/s390x/s390-virtio-ccw.c  |   8 +++
 target/s390x/cpu.h          |  26 +++++++
 target/s390x/cpu_models.c   |  97 +++++++++++---------------
 target/s390x/cpu_models.h   |   1 +
 target/s390x/excp_helper.c  |  12 ++--
 target/s390x/gen-features.c |  87 +++++++++++++++++++++++
 target/s390x/helper.h       |   6 +-
 target/s390x/insn-data.def  |  29 +++++---
 target/s390x/internal.h     |   6 +-
 target/s390x/kvm.c          |  25 +------
 target/s390x/misc_helper.c  |  59 ++++++++++++++--
 target/s390x/translate.c    | 164 ++++++++++++++++++++++++++++++++++++++++++++
 12 files changed, 415 insertions(+), 105 deletions(-)
Signature · 1 line
2.14.3