Skip to content

block: Fix BlockDriver callbacks in bdrv_drain_all_begin()

Kevin Wolf qemu-devel 2 versions – Applied

Status from this message: Applied to block-next.

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest6 patches 5 repliesApplied
  2. v14 patches 4 repliesSuperseded

Changes in v2 from the cover letter

- Added patches 5 and 6 [Paolo]
- Fixed commit message of patch 1 [Eric]

Patches in v2 Applied

#Subject and filesSizeRepliesApplied
1/6block: Make bdrv_drain_invoke() recursiveblock/io.c+11 -30 replies
2/6block: Call .drain_begin only once in bdrv_drain_all_begin()block/io.c+1 -20 replies
3/6test-bdrv-drain: Test BlockDriver callbacks for draintests/Makefile.include tests/test-bdrv-drain.c+139 -01 reply
4/6block: bdrv_drain_recurse(): Remove unused begin parameterblock/io.c+6 -60 replies
5/6block: Don't wait for requests in bdrv_drain*_end()block/io.c+0 -22 replies
6/6block: Unify order in drain functionsblock/io.c+8 -40 replies

Reviews trailers per patch

2 of 6 patches have a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchPaolo BonziniStefan HajnocziEric Blake
SeriesR-b
1/6
2/6
3/6R-b
4/6
5/6R-b R-b
6/6

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.

Read the v2 thread

Cover letter [Qemu-devel] [PATCH v2 0/6] block: Fix BlockDriver callbacks in bdrv_drain_all_begin()

I was looking into the drain functions in order to develop them a bit in the direction that Fam suggested, to unify the code between bdrv_drain() and bdrv_drain_all() a bit more, and maybe to find a place to take coroutine locks for graph changes.

The first thing I found is a bug in bdrv_drain_all(), so I'm already sending this part before I have made much progress with my actual plan.

v2:
- Added patches 5 and 6 [Paolo]
- Fixed commit message of patch 1 [Eric]

Kevin Wolf (6):
block: Make bdrv_drain_invoke() recursive
block: Call .drain_begin only once in bdrv_drain_all_begin()
test-bdrv-drain: Test BlockDriver callbacks for drain
block: bdrv_drain_recurse(): Remove unused begin parameter
block: Don't wait for requests in bdrv_drain*_end()
block: Unify order in drain functions

 block/io.c              |  31 +++++++----
 tests/test-bdrv-drain.c | 137 ++++++++++++++++++++++++++++++++++++++++++++++++
 tests/Makefile.include  |   2 +
 3 files changed, 159 insertions(+), 11 deletions(-)
 create mode 100644 tests/test-bdrv-drain.c
Signature · 1 line
2.13.6