ddbridge: error handling improvements
Get series with b4
b4 am [email protected]Versions newest first
- v1 Latest2 patches 4 repliesIn review
Patches in v1 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/2 | ddbridge: improve error handling logic on fe attach failuresdrivers/ | +22 | 0 replies | |
| 2/2 | ddbridge: don't break on single/last port attach failuredrivers/ | +1 | 4 replies |
Reviews trailers per patch
No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.
Cover letter [PATCH 0/2] ddbridge: error handling improvements
From: Daniel Scheller <[email protected]>
Two commits which will improve the error handling when attaching of (tuner) frontends fail, which complements the recent fixes in the DVB core (esp. dvb_frontend.c), making sure that on failure there won't be any frontend drivers left with a usecount > 0 and thus can be unloaded without -f on rmmod.
Also, don't miserably fail and stop hard when a single frontend failed to attach as other frontends connected to the current (or even other) bridge(s) can still work perfectly fine, so rather initialise as much as possible. (If a single PCI device fails to init, the kernel doesn't stop probing everything else on the bus)
This goes ontop of the ddbridge-0.9.32 bump (see [1]) which should have been merged for kernel 4.15rc1 originally, but unfortunately wasn't. No idea (didn't test) if this applies without the 0.9.32 changes (and please don't try to find out to avoid any merge errors/ conflicts - thanks.).
[1] http://www.spinics.net/lists/linux-media/msg123707.html
Daniel Scheller (2):
[media] ddbridge: improve error handling logic on fe attach failures [media] ddbridge: don't break on single/last port attach failure
drivers/media/pci/ddbridge/ddbridge-core.c | 51 ++++++++++++++---------------- 1 file changed, 23 insertions(+), 28 deletions(-)
Signature · 1 line
2.13.6