Skip to content

reroll of cc/skip-to-optional-val

Junio C Hamano git 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v2 Latest3 of 7 patches 8 repliesIn review

3 of 7 patches are in this archive. The cover letter announces 7.

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
5/7diff: use skip-to-optional-val in parsing --relativediff.c+3 -47 replies
6/7t4045: reindent to make helpers readablet/t4045-diff-relative.sh+50 -450 replies
7/7t4045: test 'diff --relative' for realt/t4045-diff-relative.sh+20 -41 reply

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v2 yet.

Read the v2 thread

Cover letter [PATCH v2 0/7] reroll of cc/skip-to-optional-val

I'm sending out only the last three parts, as the changes necessary to 03/07 that incorrectly used the variant without _default() to overwrite options->prefix should be trivally obvious.

05/07 uses the _default() variant so that the caller can react differently to "--relative" from "--relative=" correctly.

06/07 is an update to t4045, so that the change made in 07/07 becomes readable.

07/07 updates the test to verify the change in 05/07. I just made sure that these tests catch it if we deliberately reintroduce the broken version from Christian's series on top.

Junio C Hamano (3):
diff: use skip-to-optional-val in parsing --relative
t4045: reindent to make helpers readable
t4045: test 'diff --relative' for real

 builtin/index-pack.c     |  11 ++---
 diff.c                   |  50 +++++++--------------
 git-compat-util.h        |  23 ++++++++++
 strbuf.c                 |  20 +++++++++
 t/t4045-diff-relative.sh | 111 ++++++++++++++++++++++++++++-------------------
 5 files changed, 128 insertions(+), 87 deletions(-)
Signature · 1 line
2.15.1-480-gbc5668f98a