fixes for split index mode
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v3 Latest3 patches 21 repliesIn review
- v23 patches 10 repliesSuperseded
- v13 patches 16 repliesSuperseded
Patches in v3 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/3 | read-cache: fix reading the shared index for other reposcache-tree.c cache.h read-cache.c +2 more | +20 | 15 replies | |
| 2/3 | split-index: don't write cache tree with null oid entriescache.h read-cache.c split-index.c +1 more | +24 | 0 replies | |
| 3/3 | travis: run tests with GIT_TEST_SPLIT_INDEXci/ | +4 | 0 replies |
Reviews trailers per patch
None of the 3 patches has a Reviewed-by or Acked-by.
| Patch | Brandon Williams | Lars Schneider | Junio C Hamano | Thomas Gummerer |
|---|---|---|---|---|
| Series | Helped-by | |||
| 1/3 | Helped-by | |||
| 2/3 | ||||
| 3/3 | Helped-by | Helped-by |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 4 reviewers.
Cover letter [PATCH v3 0/3] fixes for split index mode
Thanks Brandon and Lars for comments on the previous round.
Previous rounds were at <[email protected]> and <[email protected]>.
Changes since the previous round:
- reworked the patches to no longer try to use struct repository for worktrees, but pass gitdir into read_index_from instead (Thanks Brandon :)). So the fixes that were in 1/3 and 2/3 previously are now in 1/3
- 2/3 now fixes t7009 properly. I thought it was fixed before, but it probably just passed the tests because of the GIT_TEST_SPLIT_INDEX "randomness".
- The travis job is now only running the 64-bit linux build with split index mode to save even more cycles.
- As this wasn't picked up anywhere yet, I took the freedom to rebase this onto the current master, which includes sg/travis-fixes, which made it a bit easier for me to test. If this makes the life harder for anyone reviewing this let me know and I can base it on the same commit previous iterations were based on.
Thomas Gummerer (3):
read-cache: fix reading the shared index for other repos
split-index: don't write cache tree with null sha1 entries
travis: run tests with GIT_TEST_SPLIT_INDEX
cache-tree.c | 2 +- cache.h | 8 +++++--- ci/run-linux32-build.sh | 1 + ci/run-tests.sh | 4 ++++ read-cache.c | 25 ++++++++++++++----------- repository.c | 2 +- revision.c | 3 ++- split-index.c | 2 ++ t/t1700-split-index.sh | 19 +++++++++++++++++++ 9 files changed, 49 insertions(+), 17 deletions(-)
Signature · 1 line
2.16.0.rc1.238.g530d649a79