Skip to content

video: udlfb: (not only) Logging cleanup

Ladislav Michl linux-fbdev 2 versions – Applied

Status from this message: I queued patches #1-4 for v4.16, thanks.

Get series with b4
b4 am 20180104193623.GA22612@lenoch

Versions newest first · linked by author and title

  1. v2 Latest5 patches 4 repliesApplied
  2. v16 patches 0 repliesSuperseded

Changes in v2 from the cover letter

- Dropped patch "Delete error messages for failed allocations"
- Dropped patch "Remove unnecessary 'return'"
- Added patch "Remove noisy warnings"
- Reordered patches
- Rebased against next-20180104
Please note as kernel compilation fails with:
kernel/exit.o: In function `__crc_abort':
exit.c:(*ABS*+0xc0e2ec8b): multiple definition of `__crc_abort' Makefile:1029: recipe for target 'vmlinux' failed
this patchset is not runtime tested.

Patches in v2 Applied

#Subject and filesSizeRepliesApplied
1/5video: udlfb: Remove unnecessary local variabledrivers/video/fbdev/udlfb.c+2 -60 replies
2/5video: udlfb: Remove redundant gdev variabledrivers/video/fbdev/udlfb.c include/video/udlfb.h+1 -40 replies
3/5video: udlfb: Remove noisy warningsdrivers/video/fbdev/udlfb.c+0 -200 replies
4/5video: udlfb: Do not name private data 'dev'drivers/video/fbdev/udlfb.c include/video/udlfb.h+208 -2080 replies
5/5video: udlfb: Switch from the pr_*() to the dev_*() logging functionsdrivers/video/fbdev/udlfb.c+106 -1130 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v2 yet.

Read the v2 thread

Cover letter [PATCH v2 0/5] video: udlfb: (not only) Logging cleanup

This patchset is a side product of debugging on unreliable USB host where devices saw a lot of disconnects. It turned out that udlfb logging is just too noisy to be usefull as produced syslog is hard to read.

Hence this attempt to clean things up.

Comments and suggestions welcome and appreciated, as always.

Changes in v2:
- Dropped patch "Delete error messages for failed allocations"
- Dropped patch "Remove unnecessary 'return'"
- Added patch "Remove noisy warnings"
- Reordered patches
- Rebased against next-20180104
Please note as kernel compilation fails with:
kernel/exit.o: In function `__crc_abort':
exit.c:(*ABS*+0xc0e2ec8b): multiple definition of `__crc_abort' Makefile:1029: recipe for target 'vmlinux' failed
this patchset is not runtime tested.

Ladislav Michl (5):
video: udlfb: Remove unnecessary local variable
video: udlfb: Remove redundant gdev variable
video: udlfb: Remove noisy warnings
video: udlfb: Do not name private data 'dev'
video: udlfb: Switch from the pr_*() to the dev_*() logging functions

 drivers/video/fbdev/udlfb.c | 635 +++++++++++++++++++++-----------------------
 include/video/udlfb.h       |   3 +-
 2 files changed, 302 insertions(+), 336 deletions(-)
Signature · 1 line
2.15.1