Skip to content

scsi_debug: add write scattered support

Douglas Gilbert linux-scsi 3 versions – Applied

Status from this message: Applied to 4.16/scsi-queue, thanks!

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest5 patches 1 replyApplied
  2. v25 patches 6 repliesSuperseded
  3. v14 patches 6 repliesSuperseded

Changes in v3 from the cover letter

- remove over-zealous sanity check (lbdof >= bt_len) that rejected valid invocations
- change a kzalloc() failure to return SCSI_MLQUEUE_HOST_BUSY as requested by reviewer

Patches in v3 Applied

#Subject and filesSizeRepliesApplied
1/5scsi_debug: tab, kstrto changesdrivers/scsi/scsi_debug.c+87 -870 replies
2/5scsi_debug: fix group_number maskdrivers/scsi/scsi_debug.c+14 -140 replies
3/5scsi_debug: do_device_access add sg offset argumentdrivers/scsi/scsi_debug.c+8 -70 replies
4/5scsi_debug: ARRAY_SIZE and FF_MEDIA_IOdrivers/scsi/scsi_debug.c+90 -730 replies
5/5scsi_debug: add resp_write_scat functiondrivers/scsi/scsi_debug.c+176 -30 replies

Reviews trailers per patch

4 of 5 patches have a Reviewed-by or Acked-by.

PatchBart Van Assche
1/5R-b
2/5R-b
3/5R-b
4/5R-b
5/5

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v3 thread

Cover letter [PATCH v3 0/5] scsi_debug: add write scattered support

While testing the WRITE SCATTERED command support in a new sg3_utils utility (sg_write_x) it was helpful to have a target that supported this command. This command might be attractive to other kernel subsystems. Even if end devices don't support this command yet, it would most likely be a performance win if SCSI LLDs supported it (by breaking it down to a series of WRITE commands), as that would cut down the overhead of the block layer, the ULD (e.g. sd) and the SCSI midlevel.

Changes since v2:
- remove over-zealous sanity check (lbdof >= bt_len) that rejected valid invocations
- change a kzalloc() failure to return SCSI_MLQUEUE_HOST_BUSY as requested by reviewer

Changes since original version:
- fix problem when fake_rw=1, identify media access commands better with following rename
- rename FF_DIRECT_IO to FF_MEDIA_IO
- apply reviewer suggestions (Bart Van Assche)
- expand in-code comments

Douglas Gilbert (5):
scsi_debug: tab, kstrto changes
scsi_debug: fix group_number mask
scsi_debug: do_device_access add sg offset argument
scsi_debug: ARRAY_SIZE and FF_MEDIA_IO
scsi_debug: add resp_write_scat function

 drivers/scsi/scsi_debug.c | 541 +++++++++++++++++++++++++++++++---------------
 1 file changed, 366 insertions(+), 175 deletions(-)
Signature · 1 line
2.14.1