Skip to content

hv_netvsc: minor changes

Stephen Hemminger netdev 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest6 patches 1 replyIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/6hv_netvsc: copy_to_send buf can be voiddrivers/net/hyperv/netvsc.c+8 -140 replies
2/6hv_netvsc: track memory allocation failures in ethtool statsdrivers/net/hyperv/hyperv_net.h drivers/net/hyperv/netvsc_drv.c+4 -20 replies
3/6hv_netvsc: simplify function args in receive status pathdrivers/net/hyperv/hyperv_net.h drivers/net/hyperv/netvsc.c drivers/net/hyperv/netvsc_drv.c +1 more+7 -190 replies
4/6hv_netvsc: pass netvsc_device to receive callbackdrivers/net/hyperv/hyperv_net.h drivers/net/hyperv/netvsc_drv.c drivers/net/hyperv/rndis_filter.c+8 -140 replies
5/6hv_netvsc: remove open_cnt reference countdrivers/net/hyperv/hyperv_net.h drivers/net/hyperv/netvsc.c drivers/net/hyperv/rndis_filter.c+4 -100 replies
6/6hv_netvsc: empty current transmit aggregation if flow blockeddrivers/net/hyperv/hyperv_net.h drivers/net/hyperv/netvsc.c drivers/net/hyperv/netvsc_drv.c +1 more+17 -100 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH net-next 0/6] hv_netvsc: minor changes

This includes minor cleanup of code in send and receive path and also a new statistic to check for allocation failures. This also eliminates some of the extra RCU when not needed.

There is a theoritical bug where buffered data could be blocked for longer than necessary if the ring buffer got full. This has not been seen in the wild, found by inspection.

The reference count between net device and internal RNDIS is not needed.

Stephen Hemminger (6):
hv_netvsc: copy_to_send buf can be void
hv_netvsc: track memory allocation failures in ethtool stats
hv_netvsc: simplify function args in receive status path
hv_netvsc: pass netvsc_device to receive callback
hv_netvsc: remove open_cnt reference count
hv_netvsc: empty current transmit aggregation if flow blocked

 drivers/net/hyperv/hyperv_net.h   |  9 ++++----
 drivers/net/hyperv/netvsc.c       | 44 ++++++++++++++++++++-------------------
 drivers/net/hyperv/netvsc_drv.c   | 33 +++++++----------------------
 drivers/net/hyperv/rndis_filter.c | 29 +++++++++++---------------
 4 files changed, 47 insertions(+), 68 deletions(-)
Signature · 1 line
2.11.0