Skip to content

regmap: follow-up for ("regmap: allow to disable all locking mechanisms")

Bartosz Golaszewski lkml 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest3 patches 7 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/3regmap: rename regmap_lock_unlock_empty() to regmap_lock_unlock_none()drivers/base/regmap/regmap.c+2 -20 replies
2/3regmap: don't create the debugfs entries if locking is disableddrivers/base/regmap/internal.h drivers/base/regmap/regmap-debugfs.c drivers/base/regmap/regmap.c+8 -05 replies
3/3regmap: duplicate the name string stored in regmapdrivers/base/regmap/regmap.c+9 -12 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 0/3] regmap: follow-up for ("regmap: allow to disable all locking mechanisms")

Hi Mark,

this series is a follow-up for my previous patch. The first commit renames the empty locking routine introduced in it - I agree with Andy that it just looks better.

The second patch disables the debugfs entries when locking is disabled as suggested by Lars-Peter.

The last patch is optional - feel free to drop it if you think it's not necessary. I just noticed that most frameworks duplicate any name strings, if it's possible that an unaware user gives us a pointer to a temporary buffer. While I haven't found any such instance in the current kernel, I believe it would make regmap safer for the future.

Bartosz Golaszewski (3):
regmap: rename regmap_lock_unlock_empty() to regmap_lock_unlock_none()
regmap: don't create the debugfs entries if locking is disabled
regmap: duplicate the name string stored in regmap

 drivers/base/regmap/internal.h       |  2 ++
 drivers/base/regmap/regmap-debugfs.c |  5 +++++
 drivers/base/regmap/regmap.c         | 15 ++++++++++++---
 3 files changed, 19 insertions(+), 3 deletions(-)
Signature · 1 line
2.15.1