piix4: cleanup and improvements
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v4 Latest16 patches 7 repliesIn review
- v316 patches 13 repliesSuperseded
- v215 patches 1 replySuperseded
Earlier versions · 1
| Version | Posted | Patches | Replies | Status |
|---|---|---|---|---|
| v1 | 15 patches | 0 replies | Superseded |
Changes in v4 from the cover letter
- don't use DeviceClass->init function (patch 4, Marcel Apfelbaum)
- renamed pci to pci_dev (patch 5, Marcel Apfelbaum)
- add impl.{min,max}_access_size (patch 6, Michael S. Tsirkin)
- added Acked-by tags
Patches in v4 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/16 | fdc: move object structures to header filehw/ include/ | +103 | 1 reply | |
| 2/16 | serial/parallel: move object structures to header filehw/ hw/ hw/ +2 more | +53 | 0 replies | |
| 3/16 | mc146818rtc: move structure to header filehw/ include/ | +29 | 0 replies | |
| 4/16 | mc146818rtc: always register rtc to rtc listhw/ | +1 | 0 replies | |
| 5/16 | piix4: rename some variables in realize functionhw/ | +7 | 0 replies | |
| 6/16 | piix4: add Reset Control Registerhw/ | +39 | 0 replies | |
| 7/16 | piix4: add a i8259 interrupt controller as specified in datasheethw/ hw/ include/ | +41 | 0 replies | |
| 8/16 | piix4: add a i8257 dma controller as specified in datasheethw/ hw/ | +3 | 0 replies | |
| 9/16 | piix4: add a i8254 pit controller as specified in datasheethw/ hw/ | +4 | 0 replies | |
| 10/16 | piix4: add a i8042 keyboard/mouse controller as specified in datasheethw/ hw/ | +3 | 2 replies | |
| 11/16 | piix4: add a floppy controller, 1 parallel port and 2 serial portshw/ hw/ | +89 | 1 reply | |
| 12/16 | piix4: add a mc146818rtc controller as specified in datasheethw/ hw/ | +12 | 1 reply | |
| 13/16 | piix4: add a speaker as specified in datasheethw/ | +6 | 0 replies | |
| 14/16 | piix4: convert reset function to QOMhw/ | +4 | 0 replies | |
| 15/16 | piix4: rename PIIX4 object to piix4-isahw/ hw/ include/ | +4 | 1 reply | |
| 16/16 | piix4: we can now instanciate a PIIX4 with -devicehw/ | +0 | 0 replies |
Reviews trailers per patch
All 16 patches have a Reviewed-by or Acked-by.
| Patch | Michael S. Tsirkin | Paolo Bonzini | Philippe Mathieu-Daudé | John Snow |
|---|---|---|---|---|
| 1/16 | A-b | A-b | A-b | |
| 2/16 | A-b | A-b | ||
| 3/16 | A-b | A-b | ||
| 4/16 | A-b | A-b | ||
| 5/16 | A-b | A-b | ||
| 6/16 | A-b | A-b | ||
| 7/16 | A-b | A-b | ||
| 8/16 | A-b | A-b | ||
| 9/16 | A-b | A-b | ||
| 10/16 | A-b | A-b | ||
| 11/16 | A-b | A-b | ||
| 12/16 | A-b | A-b | ||
| 13/16 | A-b | A-b | ||
| 14/16 | A-b | A-b | ||
| 15/16 | A-b | A-b | R-b | |
| 16/16 | A-b | A-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 4 reviewers.
Cover letter [Qemu-devel] [PATCH v4 00/16] piix4: cleanup and improvements
Hi,
This patchset is a cleanup of the PIIX4 PCI-ISA bridge. Lots of devices are moved from MIPS Malta board (which has a PIIX4) to PIIX4, where devices belong. This lets us reuse PIIX4 in other machines, while not loosing any functionality.
Last patch allows adding a new PIIX4 device directly from command line. Note that this will work only as long no other ISA bus already exist on the machine.
Hervé
Changes v3 -> v4:
- don't use DeviceClass->init function (patch 4, Marcel Apfelbaum)
- renamed pci to pci_dev (patch 5, Marcel Apfelbaum)
- add impl.{min,max}_access_size (patch 6, Michael S. Tsirkin)
- added Acked-by tags
Changes v2 -> v3:
- rebased on master and fixed conflicts
- added patch 14 (convert reset function to QOM)
- use TYPE_PIIX4_PCI_DEVICE in Malta board (patch 15, Philippe Mathieu-Daudé)
Changes v1 -> v2:
- fixed compilation on CentOS 6 (patch 1)
- automatically create serial/parallel chardevs if not provided (patch 11)
Hervé Poussineau (16):
fdc: move object structures to header file serial/parallel: move object structures to header file
mc146818rtc: move structure to header file
mc146818rtc: always register rtc to rtc list
piix4: rename some variables in realize function
piix4: add Reset Control Register
piix4: add a i8259 interrupt controller as specified in datasheet
piix4: add a i8257 dma controller as specified in datasheet
piix4: add a i8254 pit controller as specified in datasheet
piix4: add a i8042 keyboard/mouse controller as specified in datasheet
piix4: add a floppy controller, 1 parallel port and 2 serial ports
piix4: add a mc146818rtc controller as specified in datasheet
piix4: add a speaker as specified in datasheet
piix4: convert reset function to QOM
piix4: rename PIIX4 object to piix4-isa
piix4: we can now instanciate a PIIX4 with -device
hw/block/fdc.c | 102 ---------------------- hw/char/parallel.c | 31 +------ hw/char/serial-isa.c | 13 +-- hw/isa/piix4.c | 187 ++++++++++++++++++++++++++++++++++++----- hw/mips/mips_malta.c | 74 +++++++--------- hw/ppc/pnv.c | 2 +- hw/timer/mc146818rtc.c | 36 +------- include/hw/block/fdc.h | 103 +++++++++++++++++++++++ include/hw/char/isa.h | 50 +++++++++++ include/hw/char/serial.h | 1 - include/hw/i386/pc.h | 1 - include/hw/isa/isa.h | 3 + include/hw/timer/mc146818rtc.h | 29 +++++++ 13 files changed, 386 insertions(+), 246 deletions(-) create mode 100644 include/hw/char/isa.h
Signature · 1 line
2.11.0