mkfs: various cleanups
Get series with b4
b4 am [email protected]Versions newest first
- v1 Latest7 patches 15 repliesIn review
Patches in v1 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/7 | mkfs: use opts parameter during option parsingmkfs/ | +30 | 1 reply | |
| 2/7 | mkfs: simplify minimum log size calculationinclude/ mkfs/ mkfs/ +1 more | +52 | 1 reply | |
| 3/7 | mkfs: protofile only needs to be set up oncemkfs/ | +0 | 1 reply | |
| 4/7 | mkfs: support arbitrary conflict specificationmkfs/ | +130 | 4 replies | |
| 5/7 | mkfs: convert subopt name,val pairs to enums and declared arraysmkfs/ | +153 | 1 reply | |
| 6/7 | mkfs: resolve sector size CLI conflictsmkfs/ | +31 | 3 replies | |
| 7/7 | mkfs: remove logarithm based CLI optionsmkfs/ | +10 | 4 replies |
Reviews trailers per patch
5 of 7 patches have a Reviewed-by or Acked-by.
| Patch | Darrick J. Wong |
|---|---|
| 1/7 | R-b |
| 2/7 | R-b |
| 3/7 | R-b |
| 4/7 | |
| 5/7 | R-b |
| 6/7 | |
| 7/7 | R-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [PATCH 0/7] mkfs: various cleanups
Hi folks,
This patchset follows up the mkfs refactoring and cleans up some of the loose ends in that patchset. The first patch makes all the option parsing use option table poitners consistently. The second patch gets rid of mkfs/maxtrres.c as we don't need to build a whole new superblock from individual config state anymore. The third patch fixes a double call to setup the protofile.
THe next three patches allow the option table to specify conflicts with options ouside the immediate subsystem. This cleans up the implicit index in teh subopt name arrays and fixes some suboptimal error messages.
Finally, the last patch removes all the log-based size options for different parameters. We don't use them anywhere in xfstests, and very few people use them, so just remove all the redundant options and clean up the code to consistently calculate the log based values needed in the superblock.
Thoughts, comments, flames all welcome...
-Dave.