Skip to content

Support for arbitrary reggroups

Stafford Horne openrisc 1 version New

Get series with b4
b4 am [email protected]

Versions newest first

  1. v3 Latest4 patches 0 repliesNew

Changes in v3 from the cover letter

* Fixed NEWS entry XML/descriptions typo seggested by Petro
* Rebased on latest upstream/master.

Patches in v3 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/4reggroups: Add test and docs for `info reg $reggroup` featuregdb/doc/gdb.texinfo gdb/infcmd.c gdb/testsuite/gdb.base/reggroups.c +1 more+79 -24 replies
1/4reggroups: Add test and docs for `info reg $reggroup` feature+0 -00 replies
1/4reggroups: Add test and docs for `info reg $reggroup` feature+0 -00 replies
2/4reggroups: Convert reggroups from post_init to pre_initgdb/reggroups.c+4 -111 reply
3/4reggroups: Create reggroup_gdbarch_new for dynamic reggroupsgdb/reggroups.c gdb/reggroups.h+16 -01 reply
4/4tdesc: handle arbitrary strings in tdesc_register_in_reggroup_pgdb/NEWS gdb/doc/gdb.texinfo gdb/target-descriptions.c +2 more+53 -412 replies
4/4tdesc: handle arbitrary strings in tdesc_register_in_reggroup_p+0 -01 reply
4/4tdesc: handle arbitrary strings in tdesc_register_in_reggroup_p+0 -00 replies
4/4tdesc: handle arbitrary strings in tdesc_register_in_reggroup_p+0 -00 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v3 yet.

Read the v3 thread

Cover letter [OpenRISC] [PATCH v3 0/4] Support for arbitrary reggroups

Hello,

(Its been some time since v2, but now that openrisc is upstream I can focus on this

There were not many concerns raised with v2. One possible issue with v3 is that the reggroups struct uses 'char *' for strings. We now compare std::string vs 'char *' which is a bit clumsy, but I didnt think it calls for converting reggroups strings to 'std::string' yet.)

Onto the change:

Traditionally registers have been limited to names like "vector", "general", "system" which are hard coded in the gdbarch. This patch allows additional reggroups to be defined by the xml target description.

This is necessary for architectures like OpenRISC which have many registers.

This series also adds documentation on tests for the feature of listing register groups via the "info reg $reggroup" command.

-Stafford

--

Changes since v2
* Fixed NEWS entry XML/descriptions typo seggested by Petro
* Rebased on latest upstream/master.

Changes since v1
* On 'info reg $reggroup' test and docs patch
- Suggested by Eli - Fix changelog
- Suggested by Simon

Quoted 5 lines

Added help text in 'help info registers'
Fixed 'register' typos
Fixed style of test program
Fixed copyright '2017'
Fixed code styles in expect

* On 'arbitrary strings' patch
- Suggested by Simon

Quoted 1 line

Allow for freeing reggroups

- Suggested by Eli

Quoted 1 line

Add documentation for this feature

Stafford Horne (4):
reggroups: Add test and docs for info reg $reggroup feature
reggroups: Convert reggroups from post_init to pre_init
reggroups: Create reggroup_gdbarch_new for dynamic reggroups
tdesc: handle arbitrary strings in tdesc_register_in_reggroup_p

 gdb/NEWS                             |  7 ++++
 gdb/doc/gdb.texinfo                  | 14 +++++--
 gdb/infcmd.c                         |  8 +++-
 gdb/reggroups.c                      | 27 +++++++------
 gdb/reggroups.h                      |  4 ++
 gdb/target-descriptions.c            | 74 ++++++++++++++++++------------------
 gdb/testsuite/gdb.base/reggroups.c   |  5 +++
 gdb/testsuite/gdb.base/reggroups.exp | 63 ++++++++++++++++++++++++++++++
 gdb/testsuite/gdb.xml/extra-regs.xml |  1 +
 gdb/testsuite/gdb.xml/tdesc-regs.exp |  3 ++
 10 files changed, 152 insertions(+), 54 deletions(-)
 create mode 100644 gdb/testsuite/gdb.base/reggroups.c
 create mode 100644 gdb/testsuite/gdb.base/reggroups.exp
Signature · 1 line
2.13.6