Skip to content

replay additions

Pavel Dovgalyuk qemu-devel 8 versions – In review

Get series with b4
b4 am 20180227095135.1060.36549.stgit@pasha-VirtualBox

Versions newest first · linked by author and title

  1. v7 Latest22 patches 6 repliesIn review
  2. v6 RFC20 patches 27 repliesSuperseded
  3. v5 RFC24 patches 2 repliesSuperseded
Earlier versions · 5
VersionPostedPatchesRepliesStatus
v4 RFC23 patches12 repliesSuperseded
v3 RFC posting 2/230 patches18 repliesSuperseded
v3 posting 1/21 patch1 replySuperseded
v21 patch7 repliesSuperseded
v11 patch5 repliesApplied

Changes in v7 from the cover letter

- updated record/replay documentation
- removed abort() from mutex stub functions
- fixed cpu_io_recompile function

Patches in v7 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/22cpu-exec: fix exception_index handlingaccel/tcg/cpu-exec.c+4 -10 replies
2/22block: implement bdrv_snapshot_goto for blkreplayblock/blkreplay.c+8 -00 replies
3/22blkreplay: create temporary overlay for underlaying devicesblock/blkreplay.c stubs/replay.c vl.c+69 -10 replies
4/22replay: disable default snapshot for record/replayvl.c+7 -10 replies
5/22replay: fix processing async eventsreplay/replay-events.c+2 -20 replies
6/22replay: fixed replay_enable_eventsreplay/replay-events.c+5 -30 replies
7/22replay: fix save/load vm for non-empty queueinclude/sysemu/replay.h migration/savevm.c replay/replay-snapshot.c+22 -00 replies
8/22replay: added replay log format descriptiondocs/replay.txt+69 -00 replies
9/22replay: save prior value of the host clockinclude/qemu/timer.h replay/replay-internal.h replay/replay-snapshot.c +1 more+31 -00 replies
10/22replay/replay.c: bump REPLAY_VERSION againreplay/replay-internal.h replay/replay.c+2 -20 replies
11/22replay/replay-internal.c: track holding of replay_lockreplay/replay-internal.c+11 -00 replies
12/22replay: make locking visible outside replay codeinclude/sysemu/replay.h replay/replay-internal.c replay/replay-internal.h +1 more+25 -40 replies
13/22replay: push replay_mutex_lock up the call treecpus.c docs/replay.txt include/sysemu/replay.h +8 more+120 -751 reply
14/22replay: don't destroy mutex at exitreplay/replay.c+0 -10 replies
15/22replay: check return values of fwritereplay/replay-internal.c+15 -20 replies
16/22replay: avoid recursive call of checkpointsreplay/replay.c+13 -10 replies
17/22scripts/replay-dump.py: replay log dumperscripts/replay-dump.py+308 -00 replies
18/22replay: don't process async events when warping the clockreplay/replay-events.c replay/replay.c+7 -10 replies
19/22replay: save vmstate of the asynchronous eventsreplay/replay-events.c replay/replay-internal.h replay/replay-snapshot.c+30 -230 replies
20/22replay: don't drain/flush bdrv queue while RR is workingblock/io.c cpus.c+22 -21 reply
21/22replay: update documentationdocs/replay.txt+52 -200 replies
22/22tcg: fix cpu_io_recompileaccel/tcg/translate-all.c+15 -32 replies

Reviews trailers per patch

6 of 22 patches have a Reviewed-by or Acked-by.

PatchPaolo BonziniPavel Dovgalyuk
1/22
2/22
3/22
4/22
5/22A-b
6/22A-b
7/22
8/22A-b
9/22A-b
10/22A-b Reviewed-off-by
11/22T-b
12/22
13/22T-b
14/22A-b
15/22
16/22
17/22
18/22
19/22
20/22
21/22
22/22

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v7 thread

Cover letter [Qemu-devel] [ PATCH v7 00/22] replay additions

This set of patches moves replay lock upper in the function call tree. Now replay lock functions similar to BQL in older version and allows deterministic execution of the threads in icount mode.
It is also fixes some vmstate creation (and loading) issues in record/replay modes:
- VM start/stop fixes in replay mode
- overlay creation for blkreplay filter
- fixes for vmstate save/load in record/replay mode
- fixes for host clock vmstate

There is also a set of helper scripts written by Alex Bennée for debugging the record/replay code.

v6 patches with updates for v7 are available in the repository:
https://github.com/ispras/qemu/tree/rr-180207

v7 changes:
- updated record/replay documentation
- removed abort() from mutex stub functions
- fixed cpu_io_recompile function

v6 changes:
- removed BQL optimization at all
- refined replay lock patches
- removed lock/unlock from replay-audio

v5 changes:
- removed patch for narrowing BQL-protected code
- disabled bdrv_(drain/flush)_all for record/replay mode

v4 changes:
- removed upstreamed patches
- added patch for saving async queue state in replay
- minor fixes

v3 changes:
- removed upstreamed patches
- fixed bug with recursive checkpoints
- fixed bug with icount warp checkpoint

v2 changes:
- updated lock/unlock logic (as suggested by Paolo Bonzini)
- updated cpu execution loop to avoid races in setting/resetting exit request (as suggested by Paolo Bonzini)
- minor changes

---

Alex Bennée (5):
replay/replay.c: bump REPLAY_VERSION again replay/replay-internal.c: track holding of replay_lock
replay: make locking visible outside replay code
replay: push replay_mutex_lock up the call tree scripts/replay-dump.py: replay log dumper

Pavel Dovgalyuk (17):
cpu-exec: fix exception_index handling
block: implement bdrv_snapshot_goto for blkreplay
blkreplay: create temporary overlay for underlaying devices
replay: disable default snapshot for record/replay
replay: fix processing async events
replay: fixed replay_enable_events
replay: fix save/load vm for non-empty queue
replay: added replay log format description
replay: save prior value of the host clock
replay: don't destroy mutex at exit
replay: check return values of fwrite
replay: avoid recursive call of checkpoints
replay: don't process async events when warping the clock
replay: save vmstate of the asynchronous events
replay: don't drain/flush bdrv queue while RR is working
replay: update documentation
tcg: fix cpu_io_recompile

 accel/tcg/cpu-exec.c      |    5 +
 accel/tcg/translate-all.c |   18 ++-
 block/blkreplay.c         |   75 +++++++++++
 block/io.c                |   22 +++
 cpus.c                    |   26 +++-
 docs/replay.txt           |  163 +++++++++++++++++++++---
 include/qemu/timer.h      |   14 ++
 include/sysemu/replay.h   |   18 +++
 migration/savevm.c        |   13 ++
 replay/replay-audio.c     |   14 +-
 replay/replay-char.c      |   21 +--
 replay/replay-events.c    |   75 +++++------
 replay/replay-internal.c  |   47 ++++++-
 replay/replay-internal.h  |   16 ++
 replay/replay-snapshot.c  |   12 ++
 replay/replay-time.c      |   10 +
 replay/replay.c           |   62 ++++++---
 scripts/replay-dump.py    |  308 +++++++++++++++++++++++++++++++++++++++++++++
 stubs/replay.c            |    9 +
 util/main-loop.c          |   15 ++
 util/qemu-timer.c         |   12 ++
 vl.c                      |   12 +-
 22 files changed, 831 insertions(+), 136 deletions(-)
 create mode 100755 scripts/replay-dump.py
Signature · 1 line
Pavel Dovgalyuk