replay additions
Get series with b4
b4 am 20180227095135.1060.36549.stgit@pasha-VirtualBoxVersions newest first · linked by author and title
- v7 Latest22 patches 6 repliesIn review
- v6 RFC20 patches 27 repliesSuperseded
- v5 RFC24 patches 2 repliesSuperseded
Earlier versions · 5
| Version | Posted | Patches | Replies | Status |
|---|---|---|---|---|
| v4 RFC | 23 patches | 12 replies | Superseded | |
| v3 RFC posting 2/2 | 30 patches | 18 replies | Superseded | |
| v3 posting 1/2 | 1 patch | 1 reply | Superseded | |
| v2 | 1 patch | 7 replies | Superseded | |
| v1 | 1 patch | 5 replies | Applied |
Changes in v7 from the cover letter
- updated record/replay documentation
- removed abort() from mutex stub functions
- fixed cpu_io_recompile function
Patches in v7 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/22 | cpu-exec: fix exception_index handlingaccel/ | +4 | 0 replies | |
| 2/22 | block: implement bdrv_snapshot_goto for blkreplayblock/ | +8 | 0 replies | |
| 3/22 | blkreplay: create temporary overlay for underlaying devicesblock/ stubs/ vl.c | +69 | 0 replies | |
| 4/22 | replay: disable default snapshot for record/replayvl.c | +7 | 0 replies | |
| 5/22 | replay: fix processing async eventsreplay/ | +2 | 0 replies | |
| 6/22 | replay: fixed replay_enable_eventsreplay/ | +5 | 0 replies | |
| 7/22 | replay: fix save/load vm for non-empty queueinclude/ migration/ replay/ | +22 | 0 replies | |
| 8/22 | replay: added replay log format descriptiondocs/ | +69 | 0 replies | |
| 9/22 | replay: save prior value of the host clockinclude/ replay/ replay/ +1 more | +31 | 0 replies | |
| 10/22 | replay/replay.c: bump REPLAY_VERSION againreplay/ replay/ | +2 | 0 replies | |
| 11/22 | replay/replay-internal.c: track holding of replay_lockreplay/ | +11 | 0 replies | |
| 12/22 | replay: make locking visible outside replay codeinclude/ replay/ replay/ +1 more | +25 | 0 replies | |
| 13/22 | replay: push replay_mutex_lock up the call treecpus.c docs/ include/ +8 more | +120 | 1 reply | |
| 14/22 | replay: don't destroy mutex at exitreplay/ | +0 | 0 replies | |
| 15/22 | replay: check return values of fwritereplay/ | +15 | 0 replies | |
| 16/22 | replay: avoid recursive call of checkpointsreplay/ | +13 | 0 replies | |
| 17/22 | scripts/replay-dump.py: replay log dumperscripts/ | +308 | 0 replies | |
| 18/22 | replay: don't process async events when warping the clockreplay/ replay/ | +7 | 0 replies | |
| 19/22 | replay: save vmstate of the asynchronous eventsreplay/ replay/ replay/ | +30 | 0 replies | |
| 20/22 | replay: don't drain/flush bdrv queue while RR is workingblock/ cpus.c | +22 | 1 reply | |
| 21/22 | replay: update documentationdocs/ | +52 | 0 replies | |
| 22/22 | tcg: fix cpu_io_recompileaccel/ | +15 | 2 replies |
Reviews trailers per patch
6 of 22 patches have a Reviewed-by or Acked-by.
| Patch | Paolo Bonzini | Pavel Dovgalyuk |
|---|---|---|
| 1/22 | ||
| 2/22 | ||
| 3/22 | ||
| 4/22 | ||
| 5/22 | A-b | |
| 6/22 | A-b | |
| 7/22 | ||
| 8/22 | A-b | |
| 9/22 | A-b | |
| 10/22 | A-b | Reviewed-off-by |
| 11/22 | T-b | |
| 12/22 | ||
| 13/22 | T-b | |
| 14/22 | A-b | |
| 15/22 | ||
| 16/22 | ||
| 17/22 | ||
| 18/22 | ||
| 19/22 | ||
| 20/22 | ||
| 21/22 | ||
| 22/22 |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [Qemu-devel] [ PATCH v7 00/22] replay additions
This set of patches moves replay lock upper in the function call tree. Now replay lock functions similar to BQL in older version and allows deterministic execution of the threads in icount mode.
It is also fixes some vmstate creation (and loading) issues in record/replay modes:
- VM start/stop fixes in replay mode
- overlay creation for blkreplay filter
- fixes for vmstate save/load in record/replay mode
- fixes for host clock vmstate
There is also a set of helper scripts written by Alex Bennée for debugging the record/replay code.
v6 patches with updates for v7 are available in the repository:
https://github.com/ispras/qemu/tree/rr-180207
v7 changes:
- updated record/replay documentation
- removed abort() from mutex stub functions
- fixed cpu_io_recompile function
v6 changes:
- removed BQL optimization at all
- refined replay lock patches
- removed lock/unlock from replay-audio
v5 changes:
- removed patch for narrowing BQL-protected code
- disabled bdrv_(drain/flush)_all for record/replay mode
v4 changes:
- removed upstreamed patches
- added patch for saving async queue state in replay
- minor fixes
v3 changes:
- removed upstreamed patches
- fixed bug with recursive checkpoints
- fixed bug with icount warp checkpoint
v2 changes:
- updated lock/unlock logic (as suggested by Paolo Bonzini)
- updated cpu execution loop to avoid races in setting/resetting exit request (as suggested by Paolo Bonzini)
- minor changes
---
Alex Bennée (5):
replay/replay.c: bump REPLAY_VERSION again replay/replay-internal.c: track holding of replay_lock
replay: make locking visible outside replay code
replay: push replay_mutex_lock up the call tree scripts/replay-dump.py: replay log dumper
Pavel Dovgalyuk (17):
cpu-exec: fix exception_index handling
block: implement bdrv_snapshot_goto for blkreplay
blkreplay: create temporary overlay for underlaying devices
replay: disable default snapshot for record/replay
replay: fix processing async events
replay: fixed replay_enable_events
replay: fix save/load vm for non-empty queue
replay: added replay log format description
replay: save prior value of the host clock
replay: don't destroy mutex at exit
replay: check return values of fwrite
replay: avoid recursive call of checkpoints
replay: don't process async events when warping the clock
replay: save vmstate of the asynchronous events
replay: don't drain/flush bdrv queue while RR is working
replay: update documentation
tcg: fix cpu_io_recompile
accel/tcg/cpu-exec.c | 5 + accel/tcg/translate-all.c | 18 ++- block/blkreplay.c | 75 +++++++++++ block/io.c | 22 +++ cpus.c | 26 +++- docs/replay.txt | 163 +++++++++++++++++++++--- include/qemu/timer.h | 14 ++ include/sysemu/replay.h | 18 +++ migration/savevm.c | 13 ++ replay/replay-audio.c | 14 +- replay/replay-char.c | 21 +-- replay/replay-events.c | 75 +++++------ replay/replay-internal.c | 47 ++++++- replay/replay-internal.h | 16 ++ replay/replay-snapshot.c | 12 ++ replay/replay-time.c | 10 + replay/replay.c | 62 ++++++--- scripts/replay-dump.py | 308 +++++++++++++++++++++++++++++++++++++++++++++ stubs/replay.c | 9 + util/main-loop.c | 15 ++ util/qemu-timer.c | 12 ++ vl.c | 12 +- 22 files changed, 831 insertions(+), 136 deletions(-) create mode 100755 scripts/replay-dump.py
Signature · 1 line
Pavel Dovgalyuk