Drain fixes and cleanups, part 2
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v2 Latest19 patches 7 repliesIn review
- v119 patches 14 repliesSuperseded
Changes in v2 from the cover letter
- Improved the commit message of patch 3 [Fam]
- Split the coroutine test cases in individual parts [Paolo]
- Export bdrv_(un)apply_subtree_drain rather than bdrv_do_drained_begin/end() [Paolo]
Patches in v2 No applies recorded yet
Reviews trailers per patch
8 of 19 patches have a Reviewed-by or Acked-by.
| Patch | Fam Zheng | Alberto Garcia |
|---|---|---|
| 1/19 | R-b | |
| 2/19 | R-b | R-b |
| 3/19 | R-b | |
| 4/19 | ||
| 5/19 | ||
| 6/19 | R-b | |
| 7/19 | R-b | |
| 8/19 | R-b | |
| 9/19 | ||
| 10/19 | ||
| 11/19 | ||
| 12/19 | ||
| 13/19 | ||
| 14/19 | ||
| 15/19 | ||
| 16/19 | ||
| 17/19 | ||
| 18/19 | R-b | |
| 19/19 | R-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [Qemu-devel] [PATCH v2 00/19] Drain fixes and cleanups, part 2
This is the second part of my work to fix drain and hopefully to prevent it from attracting bugs as much as it did in the past. There is definitely at least a third part coming after this, see below.
In this series, the following improvments are made:
* Fix several bugs and inconsistencies
* Create lots of unit tests for the drain functions
* Introduce bdrv_subtree_drained_begin/end() to drain a whole subtree rather than only a single node
* Use this to make bdrv_reopen() safe (graph changes in callbacks called during its internal bdrv_drain_all() frequently broke it)
Planned for part three: Make graph modifications in callbacks safe by avoiding BDRV_POLL_WHILE() calls while we're recursing through the graph. We can recurse before BDRV_POLL_WHILE(), after it or while evaluating its condition, but never call any callbacks while we're iterating child or parent lists.
v2:
- Improved the commit message of patch 3 [Fam]
- Split the coroutine test cases in individual parts [Paolo]
- Export bdrv_(un)apply_subtree_drain rather than bdrv_do_drained_begin/end() [Paolo]
Fam Zheng (1):
block: Remove unused bdrv_requests_pending
Kevin Wolf (18):
block: Assert drain_all is only called from main AioContext
block: Make bdrv_drain() driver callbacks non-recursive
test-bdrv-drain: Test callback for bdrv_drain
test-bdrv-drain: Test bs->quiesce_counter
blockjob: Pause job on draining any job BDS
test-bdrv-drain: Test drain vs. block jobs
block: Don't block_job_pause_all() in bdrv_drain_all()
block: Nested drain_end must still call callbacks
test-bdrv-drain: Test nested drain sections
block: Don't notify parents in drain call chain
block: Add bdrv_subtree_drained_begin/end()
test-bdrv-drain: Tests for bdrv_subtree_drain
test-bdrv-drain: Test behaviour in coroutine context
test-bdrv-drain: Recursive draining with multiple parents
block: Allow graph changes in subtree drained section
test-bdrv-drain: Test graph changes in drained section
commit: Simplify reopen of base
block: Keep nodes drained between reopen_queue/multiple
include/block/block.h | 15 +- include/block/block_int.h | 6 +- block.c | 66 ++++-- block/commit.c | 8 +- block/io.c | 151 +++++++++---- block/replication.c | 6 + blockjob.c | 22 +- qemu-io-cmds.c | 3 + tests/test-bdrv-drain.c | 528 +++++++++++++++++++++++++++++++++++++++++++++- 9 files changed, 717 insertions(+), 88 deletions(-)
Signature · 1 line
2.13.6