tpm: fix PS/2 devices not working on Braswell systems due CLKRUN enabled
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v2 Latest3 patches 1 replyIn review
- v14 patches 34 repliesSuperseded
Changes in v2 from the cover letter
- Add collected tags
- Drop patch that fixed a bug in the error path since was already fixed.
Patches in v2 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/3 | tpm: delete the TPM_TIS_CLK_ENABLE flagdrivers/ drivers/ drivers/ | +0 | 0 replies | |
| 2/3 | tpm: follow coding style for variable declaration in tpm_tis_core_init()drivers/ | +3 | 0 replies | |
| 3/3 | tpm: only attempt to disable the LPC CLKRUN if is already enableddrivers/ | +10 | 0 replies |
Reviews trailers per patch
All 3 patches have a Reviewed-by or Acked-by.
| Patch | Jarkko Sakkinen | James Ettle | Jeffery Miller |
|---|---|---|---|
| 1/3 | R-b T-b | ||
| 2/3 | R-b T-b | ||
| 3/3 | R-b T-b | T-b | T-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.
Cover letter [PATCH v2 0/3] tpm: fix PS/2 devices not working on Braswell systems due CLKRUN enabled
Hello,
Commit 5e572cab92f0 ("tpm: Enable CLKRUN protocol for Braswell systems") added logic in the TPM TIS driver to disable the Low Pin Count CLKRUN signal during TPM transactions.
Unfortunately this breaks other devices that are attached to the LPC bus like for example PS/2 mouse and keyboards.
The bug was reported to the Fedora kernel [0] and the kernel bugzilla [1]. This issue and the propossed solution were discussed in this [2] thread, and the reporter (Jame Ettle) confirmed that his system works again after the fix in this series.
The patches are based on top or Jarkko Sakkinen's linux-tpmdd [3] tree.
Changes since v1:
- Add collected tags
- Drop patch that fixed a bug in the error path since was already fixed.
[0]: https://bugzilla.redhat.com/show_bug.cgi?id=1498987
[1]: https://bugzilla.kernel.org/show_bug.cgi?id=197287
[2]: https://patchwork.kernel.org/patch/10119417/
[3]: git.infradead.org/users/jjs/linux-tpmdd.git
Best regards,
Javier
Javier Martinez Canillas (3):
tpm: delete the TPM_TIS_CLK_ENABLE flag
tpm: follow coding style for variable declaration in
tpm_tis_core_init()
tpm: only attempt to disable the LPC CLKRUN if is already enabled
drivers/char/tpm/tpm_tis.c | 15 --------------- drivers/char/tpm/tpm_tis_core.c | 17 +++++++++++++---- drivers/char/tpm/tpm_tis_core.h | 1 - 3 files changed, 13 insertions(+), 20 deletions(-)
Signature · 1 line
2.14.3