Skip to content

RFC drm/msm: Avoid subclassing of drm_atomic_state

Archit Taneja dri-devel linux-arm-msm 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 RFC Latest3 patches 4 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/3drm/msm/mdp5: Add global state as a private atomic objectdrivers/gpu/drm/msm/mdp/mdp5/mdp5_kms.c drivers/gpu/drm/msm/mdp/mdp5/mdp5_kms.h+113 -04 replies
2/3drm/msm/mdp5: Use the new private_obj statedrivers/gpu/drm/msm/mdp/mdp5/mdp5_kms.c drivers/gpu/drm/msm/mdp/mdp5/mdp5_mixer.c drivers/gpu/drm/msm/mdp/mdp5/mdp5_pipe.c +1 more+37 -220 replies
3/3drm/msm: Don't subclass drm_atomic_state anymoredrivers/gpu/drm/msm/mdp/mdp5/mdp5_kms.c drivers/gpu/drm/msm/mdp/mdp5/mdp5_kms.h drivers/gpu/drm/msm/msm_atomic.c +2 more+0 -1160 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [RFC 0/3] drm/msm: Avoid subclassing of drm_atomic_state

It's been recommended that we use drm_private_objs embedded in drm_atomic_state to hold shared resources instead of subclassing drm_atomic_state.

This will also help us in getting one step closer to using the atomic commit helpers instead of the msm_atomic_commit() funcs in msm_atomic.c

I've taken the drm_private_obj usage in drm_dp_mst_topology as reference. I've put this as RFC because I want others to see if the private_obj stuff is used correctly.

Archit Taneja (3):
drm/msm/mdp5: Add global state as a private atomic object drm/msm/mdp5: Use the new private_obj state drm/msm: Don't subclass drm_atomic_state anymore

 drivers/gpu/drm/msm/mdp/mdp5/mdp5_kms.c   | 104 +++++++++++++++++++++---------
 drivers/gpu/drm/msm/mdp/mdp5/mdp5_kms.h   |  29 +++++----
 drivers/gpu/drm/msm/mdp/mdp5/mdp5_mixer.c |  12 ++--
 drivers/gpu/drm/msm/mdp/mdp5/mdp5_pipe.c  |  20 +++---
 drivers/gpu/drm/msm/mdp/mdp5/mdp5_smp.c   |  17 +++--
 drivers/gpu/drm/msm/msm_atomic.c          |  31 ---------
 drivers/gpu/drm/msm/msm_drv.c             |   3 -
 drivers/gpu/drm/msm/msm_kms.h             |  14 ----
 8 files changed, 121 insertions(+), 109 deletions(-)
Signature · 7 lines
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
hosted by The Linux Foundation

_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel