Skip to content

kbuild: Fix corner caches with .cache.mk

Douglas Anderson linux-kbuild lkml 3 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest2 patches 10 repliesIn review
  2. v22 patches 2 repliesSuperseded
  3. v12 patches 0 repliesSuperseded

Changes in v3 from the cover letter

- Fix as per Masahiro Yamada (move change to main Makefile)
- Use "uid 0" as the heuristic instead of install
- Do the checking in the main Makefile instead of Kbuild.include

Patches in v3 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2kbuild: Require a 'make clean' if we detect gcc changed underneath usMakefile+9 -00 replies
2/2kbuild: Don't mess with the .cache.mk when rootMakefile scripts/Kbuild.include+8 -08 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v3 yet.

Read the v3 thread

Cover letter [PATCH v3 0/2] kbuild: Fix corner caches with .cache.mk

This two-patches fixes two corner cases with .cache.mk that have been reported. Neither problem was catastrophic, but certainly several people ran into the problem solved by the first patch (can't build after gcc upgrade) and wasted time debugging, so it's really a good idea to fix.

Sorry for the big delay between v2 and v3. I never quite caught up with email after the holidays, but hopefully better late than never...

Changes in v3:
- Fix as per Masahiro Yamada (move change to main Makefile)
- Use "uid 0" as the heuristic instead of install
- Do the checking in the main Makefile instead of Kbuild.include

Changes in v2:
- Don't error if MAKECMDGOALS is blank.

Douglas Anderson (2):
kbuild: Require a 'make clean' if we detect gcc changed underneath us
kbuild: Don't mess with the .cache.mk when root

 Makefile               | 15 +++++++++++++++
 scripts/Kbuild.include |  2 ++
 2 files changed, 17 insertions(+)
Signature · 1 line
2.16.2.660.g709887971b-goog