Marvell NAND controller rework with ->exec_op()

Quoted 4 lines · Miquel RAYNAL

Quoted 3 lines

Here it comes in [3]. I suspect the BBT parser here, here is the extract that _might_ be relevant:

[    3.372907] nand: ->exec_op() parser: pattern not found!  

Quoted 8 lines

Indeed this might be the problem, it means there is one scenario that should be handled by the parser that is missing. I am really interrogative about which one it is and to discover it, can you rebuild with

        #define DEBUG

in drivers/mtd/nand/nand_base.c too.

It was already there, check the patch I attached to my previous mail.

Quoted 2 lines

This way the core will display the patterns it try to find a match for.

The core displays already debug message, as these are displayed :

[    3.228598] nand: executing subop:
[    3.232187] nand:     ->CMD      [0x90]
[    3.236077] nand:     ->ADDR     [1 cyc: 40]
[    3.240517] nand:     ->DATA_IN  [5 B, force 8-bit]

As to your statement "the core will display the patterns it try to find a match for", how confident are you with it ? Because my reading of the following code is quite different :

			if (!nand_op_parser_match_pat(pattern, &ctx))
				continue;

			nand_op_parser_trace(&ctx);

Quoted 2 lines

Also to ease the understanding, you might add a dump_stack() right next to this error message.

Attached in [1].