python: clean up host version logic.
Get series with b4
b4 am [email protected]Versions newest first
- v1 Latest2 of 8 patches 0 repliesNew
2 of 8 patches are in this archive. The cover letter announces 8.
Patches in v1 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 3/8 | python-setuptools: check host-python version | +0 | 1 reply | |
| 3/8 | python-setuptools: check host-python version | +0 | 0 replies |
Reviews trailers per patch
No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.
Cover letter [Buildroot] [PATCH 0/8] python: clean up host version logic.
Hello,
Quoted 6 lines · Yann E. MORIN
Quoted 3 lines
However, there is one thing that I believe is missing in your patch
series:BR2_PACKAGE_PYTHON3should selectBR2_PACKAGE_HOST_PYTHON3, andBR2_PACKAGE_PYTHONshould selectBR2_PACKAGE_HOST_PYTHON.Furthermore, I believe the prompt should be hidden, because it does not make sense for the user to actually select the host version for python.
If the prompt is not user-selectable, then I don't see the point of the patch series. Indeed, you can already do:
<pkg>_DEPENDENCIES = $(if $(BR2_PACKAGE_PYTHON3),host-python3,host-python)
to use host-python3 if already built as part of the python3 build process, or fallback to host-python otherwise. We already use this construct in a number of places.
Quoted 3 lines
Besides, the current series allows for building both host-python and host-python3 in the same configuration, and we do not support this for now (or we would have made it possible for the target variant too).
Of course we support building both host-python and host-python3. What we don't support is:
- python and python3 in the same configuration
- building third-party host python modules for a host python version different from the selected target python version
Best regards,
Thomas
Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com