Skip to content

mm, hugetlb: allocation API and migration improvements

Michal Hocko linux-mm lkml 1 version Applied

Status from this message: [merged] hugetlb-mempolicy-fix-the-mbind-hugetlb-migration.patch removed from -mm tree

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest6 patches 10 repliesApplied 6/6

Patches in v1 All 6 applied

#Subject and filesSizeRepliesApplied
1/6mm, hugetlb: unify core page allocation accounting and initializationmm/hugetlb.c+29 -320 repliesApplied
2/6mm, hugetlb: integrate giga hugetlb more naturally to the allocation pathmm/hugetlb.c+14 -410 repliesApplied
3/6mm, hugetlb: do not rely on overcommit limit during migrationinclude/linux/hugetlb.h mm/hugetlb.c mm/migrate.c+99 -180 repliesApplied
4/6mm, hugetlb: get rid of surplus page accounting tricksmm/hugetlb.c+23 -390 repliesApplied
5/6mm, hugetlb: further simplify hugetlb allocation APImm/hugetlb.c+42 -369 repliesApplied
6/6hugetlb, mempolicy: fix the mbind hugetlb migrationinclude/linux/hugetlb.h mm/hugetlb.c mm/mempolicy.c+22 -190 repliesApplied

Reviews trailers per patch

All 6 patches have a Reviewed-by or Acked-by.

PatchMike KravetzNaoya HoriguchiDan Rue
1/6R-b R-b
2/6R-b R-b
3/6R-b R-b
4/6R-b R-b
5/6R-b R-b R-b R-b T-b T-b
6/6R-b R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.

Read the v1 thread

Cover letter [PATCH 0/6] mm, hugetlb: allocation API and migration improvements

Hi,
I've posted this as an RFC [1] and both Mike and Naoya seem to be OK both with patches and the approach. I have rebased this on top of [2] because there is a small conflict in mm/mempolicy.c. I know it is late in the release cycle but similarly to [2] I would really like to see this in linux-next for a longer time for a wider testing exposure.

Motivation:
this is a follow up for [3] for the allocation API and [4] for the hugetlb migration. It wasn't really easy to split those into two separate patch series as they share some code.

My primary motivation to touch this code is to make the gigantic pages migration working. The giga pages allocation code is just too fragile and hacked into the hugetlb code now. This series tries to move giga pages closer to the first class citizen. We are not there yet but having 5 patches is quite a lot already and it will already make the code much easier to follow. I will come with other changes on top after this sees some review.

The first two patches should be trivial to review. The third patch changes the way how we migrate huge pages. Newly allocated pages are a subject of the overcommit check and they participate surplus accounting which is quite unfortunate as the changelog explains. This patch doesn't change anything wrt. giga pages.
Patch #4 removes the surplus accounting hack from __alloc_surplus_huge_page. I hope I didn't miss anything there and a deeper review is really due there.
Patch #5 finally unifies allocation paths and giga pages shouldn't be any special anymore. There is also some renaming going on as well.

Shortlog
Michal Hocko (6):
mm, hugetlb: unify core page allocation accounting and initialization mm, hugetlb: integrate giga hugetlb more naturally to the allocation path mm, hugetlb: do not rely on overcommit limit during migration mm, hugetlb: get rid of surplus page accounting tricks
mm, hugetlb: further simplify hugetlb allocation API hugetlb, mempolicy: fix the mbind hugetlb migration

Diffstat:

 include/linux/hugetlb.h |   8 +-
 mm/hugetlb.c            | 338 +++++++++++++++++++++++++++---------------------
 mm/mempolicy.c          |   3 +-
 mm/migrate.c            |   3 +-
 4 files changed, 198 insertions(+), 154 deletions(-)

[1] http://lkml.kernel.org/r/[email protected]
[2] http://lkml.kernel.org/r/[email protected]
[3] http://lkml.kernel.org/r/[email protected]
[4] http://lkml.kernel.org/r/[email protected]

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to [email protected]. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"[email protected]"> [email protected] </a>