Skip to content

nvme/dm failover unification

Keith Busch dm-devel linux-block linux-nvme 2 versions – Applied

Status from this message: I queued it up, thanks.

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest5 patches 7 repliesApplied
  2. v15 patches 24 repliesSuperseded

Patches in v2 Applied

#Subject and filesSizeRepliesApplied
1/5nvme: Add more command status translationdrivers/nvme/host/core.c+7 -01 reply
2/5nvme/multipath: Consult blk_status_t for failoverdrivers/nvme/host/core.c drivers/nvme/host/multipath.c drivers/nvme/host/nvme.h+16 -421 reply
3/5block: Provide blk_status_t decoding for path errorsinclude/linux/blk_types.h+28 -01 reply
4/5nvme/multipath: Use blk_path_errordrivers/nvme/host/multipath.c+1 -131 reply
5/5dm mpath: Use blk_path_errordrivers/md/dm-mpath.c+2 -171 reply

Reviews trailers per patch

All 5 patches have a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchMike SnitzerHannes ReineckeJohannes ThumshirnChristoph Hellwig
SeriesR-b
1/5A-b R-b R-b
2/5A-b R-b R-b
3/5A-b R-b R-b
4/5A-b R-b R-b
5/5A-b R-b R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 4 reviewers.

Read the v2 thread

Cover letter [PATCHv2 0/5] nvme/dm failover unification

Native nvme multipath provided a separate NVMe status decoder, complicating maintenance as new statuses need to be accounted for. This was already diverging from the generic nvme status decoder, which has implications for other components that rely on accurate generic block errors.

This series unifies common code among nvme and device-mapper multipath so user experience regarding the failover fate of a command is the same.

v1 -> v2:

Fixed blk_status_t used for NVME_SC_LBA_RANGE.

Fixed line break formatting.

Changed name of new block API for path related errors and added kernel doc for it.

Added reviews and acks.

Keith Busch (5):
nvme: Add more command status translation nvme/multipath: Consult blk_status_t for failover
block: Provide blk_status_t decoding for path errors nvme/multipath: Use blk_path_error
dm mpath: Use blk_path_error

 drivers/md/dm-mpath.c         | 19 ++-----------------
 drivers/nvme/host/core.c      | 16 ++++++++++++----
 drivers/nvme/host/multipath.c | 44 ++-----------------------------------------
 drivers/nvme/host/nvme.h      |  5 +++--
 include/linux/blk_types.h     | 28 +++++++++++++++++++++++++++
 5 files changed, 47 insertions(+), 65 deletions(-)
Signature · 1 line
2.13.6