common linkstatus functions
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v8 Latest15 patches 8 repliesIn review
- v715 patches 3 repliesSuperseded
- v515 patches 8 repliesSuperseded
Earlier versions · 3
| Version | Posted | Patches | Replies | Status |
|---|---|---|---|---|
| v4 | 15 patches | 0 replies | Superseded | |
| v3 | 15 patches | 11 replies | Superseded | |
| v2 | 15 patches | 6 replies | Superseded |
Patches in v8 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/15 | eal: introduce atomic exchange operationlib/ lib/ lib/ +2 more | +146 | 5 replies | |
| 2/15 | ethdev: add linkstatus get/set helper functionslib/ lib/ | +67 | 0 replies | |
| 3/15 | net/virtio: use eth_linkstatus_setdrivers/ | +5 | 0 replies | |
| 4/15 | net/vmxnet3: use rte_eth_linkstatus_setdrivers/ | +3 | 0 replies | |
| 5/15 | net/dpaa2: use rte_eth_linkstatus_setdrivers/ | +10 | 0 replies | |
| 6/15 | net/nfp: use rte_eth_linkstatus functionsdrivers/ | +7 | 0 replies | |
| 7/15 | net/e1000: use rte_eth_linkstatus helpersdrivers/ drivers/ | +10 | 0 replies | |
| 8/15 | net/ixgbe: use rte_eth_linkstatus functionsdrivers/ | +13 | 0 replies | |
| 9/15 | net/sfc: use new rte_eth_linkstatus functionsdrivers/ drivers/ | +7 | 1 reply | |
| 10/15 | net/i40e: use rte_eth_linkstatus functionsdrivers/ drivers/ | +9 | 0 replies | |
| 11/15 | net/liquidio: use rte_eth_linkstatus_setdrivers/ | +4 | 0 replies | |
| 12/15 | net/thunderx: use rte_eth_linkstatus_setdrivers/ | +18 | 0 replies | |
| 13/15 | net/szedata: use _rte_eth_linkstatus_setdrivers/ | +4 | 0 replies | |
| 14/15 | net/octeontx: use rte_eth_linkstatus_setdrivers/ | +1 | 0 replies | |
| 15/15 | net/enic: use rte_eth_linkstatus_setdrivers/ drivers/ | +9 | 0 replies |
Reviews trailers per patch
1 of 15 patches has a Reviewed-by or Acked-by of their own; the series has one for all of them.
| Patch | Shijith Thotton | Konstantin Ananyev | Ferruh Yigit |
|---|---|---|---|
| Series | R-b | ||
| 1/15 | A-b | ||
| 2/15 | |||
| 3/15 | |||
| 4/15 | |||
| 5/15 | |||
| 6/15 | |||
| 7/15 | |||
| 8/15 | |||
| 9/15 | |||
| 10/15 | |||
| 11/15 | T-b | ||
| 12/15 | |||
| 13/15 | |||
| 14/15 | |||
| 15/15 |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.
Cover letter [PATCH v8 00/15] common linkstatus functions
While writing hyper-v driver, noticed a lot of unnecessary duplication of code in drivers for handling the eth_dev link status information. While consolidating this, it also became obvious that some drivers behave differently for no good reason.
It also was a good chance to introduce atomic exchange primitives in EAL because there are other places using cmpset where not necessary (such as bonding).
Mostly only compile tested only, don't have all of the hardware available (except ixgbe and virtio) to test.
v8
- fix typo in 32bit exchange
- fix build of dpaa2
- go back to same return value as original code
- reduce number of lines changed
v7
- add exchange functions for PPC64
- move linkstatus helpers to rte_ethdev_driver
- rebase to 18.02
Stephen Hemminger (15):
eal: introduce atomic exchange operation
ethdev: add linkstatus get/set helper functions
net/virtio: use eth_linkstatus_set
net/vmxnet3: use rte_eth_linkstatus_set
net/dpaa2: use rte_eth_linkstatus_set
net/nfp: use rte_eth_linkstatus functions
net/e1000: use rte_eth_linkstatus helpers
net/ixgbe: use rte_eth_linkstatus functions
net/sfc: use new rte_eth_linkstatus functions
net/i40e: use rte_eth_linkstatus functions
net/liquidio: use rte_eth_linkstatus_set
net/thunderx: use rte_eth_linkstatus_set
net/szedata: use _rte_eth_linkstatus_set
net/octeontx: use rte_eth_linkstatus_set
net/enic: use rte_eth_linkstatus_set
drivers/net/dpaa2/dpaa2_ethdev.c | 78 +++---------------- drivers/net/e1000/em_ethdev.c | 70 ++--------------- drivers/net/e1000/igb_ethdev.c | 71 ++--------------- drivers/net/enic/enic_ethdev.c | 5 +- drivers/net/enic/enic_main.c | 16 ++-- drivers/net/i40e/i40e_ethdev.c | 46 ++--------- drivers/net/i40e/i40e_ethdev_vf.c | 19 +---- drivers/net/ixgbe/ixgbe_ethdev.c | 90 ++++------------------ drivers/net/liquidio/lio_ethdev.c | 44 +---------- drivers/net/nfp/nfp_net.c | 72 ++--------------- drivers/net/octeontx/octeontx_ethdev.c | 16 +--- drivers/net/sfc/sfc_ethdev.c | 24 ++---- drivers/net/sfc/sfc_ev.c | 20 +---- drivers/net/szedata2/rte_eth_szedata2.c | 11 +-- drivers/net/thunderx/nicvf_ethdev.c | 45 +++++------ drivers/net/virtio/virtio_ethdev.c | 52 ++----------- drivers/net/vmxnet3/vmxnet3_ethdev.c | 63 +-------------- .../common/include/arch/ppc_64/rte_atomic.h | 21 ++++- .../common/include/arch/x86/rte_atomic.h | 24 ++++++ .../common/include/arch/x86/rte_atomic_32.h | 12 +++ .../common/include/arch/x86/rte_atomic_64.h | 12 +++ lib/librte_eal/common/include/generic/rte_atomic.h | 78 +++++++++++++++++++ lib/librte_ether/rte_ethdev.c | 22 +----- lib/librte_ether/rte_ethdev_driver.h | 63 +++++++++++++++ 24 files changed, 313 insertions(+), 661 deletions(-)
Signature · 1 line
2.15.1