Skip to content

Incremental rewrite of git-submodules

Prathamesh Chavan git 3 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest2 patches 1 replyIn review
  2. v22 patches 3 repliesSuperseded
  3. v12 patches 6 repliesSuperseded

Changes in v3 from the cover letter

* For the variables: super_config_url and sub_origin_url, xstrdup() was used while assigning "" to them, before freeing.

* In case of the function deinit_submodule, since the orignal code doesn't die upon failure of the function mkdir(), printf was used instead of die_errno.

Patches in v3 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2submodule: port submodule subcommand 'sync' from shell to Cbuiltin/submodule--helper.c git-submodule.sh+194 -560 replies
2/2submodule: port submodule subcommand 'deinit' from shell to Cbuiltin/submodule--helper.c git-submodule.sh+148 -540 replies

Reviews trailers per patch

None of the 2 patches has a Reviewed-by or Acked-by.

PatchChristian CouderStefan Beller
1/2Mentored-by Mentored-by
2/2Mentored-by Mentored-by

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v3 thread

Cover letter [PATCH v3 0/2] Incremental rewrite of git-submodules

Changes in v3:

* For the variables: super_config_url and sub_origin_url, xstrdup() was used while assigning "" to them, before freeing.

* In case of the function deinit_submodule, since the orignal code doesn't die upon failure of the function mkdir(), printf was used instead of die_errno.

As before you can find this series at:
https://github.com/pratham-pc/git/commits/patch-series-2

And its build report is available at:
https://travis-ci.org/pratham-pc/git/builds/
Branch: patch-series-2
Build #197

Prathamesh Chavan (2):
submodule: port submodule subcommand 'sync' from shell to C
submodule: port submodule subcommand 'deinit' from shell to C

 builtin/submodule--helper.c | 340 ++++++++++++++++++++++++++++++++++++++++++++
 git-submodule.sh            | 112 +--------------
 2 files changed, 342 insertions(+), 110 deletions(-)
Signature · 1 line
2.15.1

Read the cover letter in its thread