Skip to content

ASoC: (minor) atmel cleanup

Ladislav Michl alsa-devel 1 version In review

Get series with b4
b4 am 20180115075213.GA10762@lenoch

Versions newest first

  1. v1 Latest5 patches 7 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/5ASoC: sam9g20_wm8731: use dev_*() logging functionssound/soc/atmel/sam9g20_wm8731.c+8 -91 reply
2/5ASoC: sam9x5_wm8731: Drop 'ASoC' prefix from error messagessound/soc/atmel/sam9x5_wm8731.c+5 -71 reply
3/5ASoC: sam9x5_wm8731: Return -ENODEV when probe does not find OF nodesound/soc/atmel/sam9x5_wm8731.c+2 -43 replies
4/5ASoC: sam9x5_wm8731: Fix OF node reference countingsound/soc/atmel/sam9x5_wm8731.c+12 -152 replies
5/5ASoC: atmel_wm8904: Return -ENODEV when probe does not find OF nodesound/soc/atmel/atmel_wm8904.c+2 -40 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 0/5] ASoC: (minor) atmel cleanup

Hi there!

this patchset is a side product of reading ALSA code while trying to support new hardware. Nothing special here, just an attempt to make those three drivers to look more similar. Only patch 4 fixes actual problem, but:
1) this particular issue is present almost everywhere (as far as I looked) where of_node_put is used in ALSA. Perhaps coccinelle people could help?
2) seems noone bothered as OF_DYNAMIC is mostly disabled

Compile tested only.

Ladislav Michl (5):
ASoC: sam9g20_wm8731: use dev_*() logging functions
ASoC: sam9x5_wm8731: Drop 'ASoC' prefix from error messages
ASoC: sam9x5_wm8731: Return -ENODEV when probe does not find OF node
ASoC: sam9x5_wm8731: Fix OF node reference counting
ASoC: atmel_wm8904: Return -ENODEV when probe does not find OF node

 sound/soc/atmel/atmel_wm8904.c   |  6 ++----
 sound/soc/atmel/sam9g20_wm8731.c | 17 +++++++--------
 sound/soc/atmel/sam9x5_wm8731.c  | 45 +++++++++++++++++-----------------------
 3 files changed, 29 insertions(+), 39 deletions(-)
Signature · 1 line
2.15.1