Skip to content

nd/shared-index-fix update

Nguyễn Thái Ngọc Duy git 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest3 patches 2 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/3read-cache.c: change type of "temp" in write_shared_index()read-cache.c+11 -90 replies
1/3read-cache.c: change type of "temp" in write_shared_index()read-cache.c+11 -90 replies
2/3read-cache.c: move tempfile creation/cleanup out of write_shared_indexread-cache.c+17 -160 replies
2/3read-cache.c: move tempfile creation/cleanup out of write_shared_indexread-cache.c+17 -160 replies
3/3read-cache: don't write index twice if we can't write shared indexread-cache.c t/t1700-split-index.sh+22 -24 replies
3/3read-cache: don't write index twice if we can't write shared indexread-cache.c t/t1700-split-index.sh+22 -20 replies

Reviews trailers per patch

None of the 6 patches has a Reviewed-by or Acked-by.

PatchThomas Gummerer
1/3
1/3
2/3
2/3
3/3Helped-by Helped-by
3/3Helped-by Helped-by

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH 0/3] nd/shared-index-fix update

This only changes the last patch to correct the test prerequisite and a couple minor refinements. Interdiff:

t/t1700-split-index.sh +4 -4
index 5494389dbb..d2a8e0312a 100755
@@ -401,7 +401,7 @@ done <<\EOF
 0642 -rw-r---w-
 EOF
 
-test_expect_success POSIXPERM 'graceful handling splitting index is not allowed' '
+test_expect_success SANITY 'graceful handling when splitting index is not allowed' '
 	test_create_repo ro &&
 	(
 		cd ro &&
@@ -409,11 +409,11 @@ test_expect_success POSIXPERM 'graceful handling splitting index is not allowed'
 		git update-index --split-index &&
 		test -f .git/sharedindex.*
 	) &&
-	test_when_finished "chmod -R u+w ro" &&
-	chmod -R u-w ro &&
 	cp ro/.git/index new-index &&
+	test_when_finished "chmod u+w ro/.git" &&
+	chmod u-w ro/.git &&
 	GIT_INDEX_FILE="$(pwd)/new-index" git -C ro update-index --split-index &&
-	chmod -R u+w ro &&
+	chmod u+w ro/.git &&
 	rm ro/.git/sharedindex.* &&
 	GIT_INDEX_FILE=new-index git ls-files >actual &&
 	echo initial.t >expected &&

Nguyễn Thái Ngọc Duy (3):
read-cache.c: change type of "temp" in write_shared_index() read-cache.c: move tempfile creation/cleanup out of write_shared_index
read-cache: don't write index twice if we can't write shared index

 read-cache.c           | 40 ++++++++++++++++++++++------------------
 t/t1700-split-index.sh | 19 +++++++++++++++++++
 2 files changed, 41 insertions(+), 18 deletions(-)
Signature · 1 line
2.16.0.47.g3d9b0fac3a