Add "git rebase --show-current-patch"
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v3 Latest3 patches 3 repliesIn review
- v23 patches 10 repliesSuperseded
- v12 patches 13 repliesSuperseded
Patches in v3 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/3 | am: add --show-current-patchDocumentation/ builtin/ contrib/ +1 more | +39 | 0 replies | |
| 2/3 | rebase: add --show-current-patchDocumentation/ builtin/ contrib/ +6 more | +71 | 0 replies | |
| 3/3 | rebase: introduce and use pseudo-ref REBASE_HEADDocumentation/ builtin/ contrib/ +6 more | +25 | 0 replies |
Reviews trailers per patch
None of the 3 patches has a Reviewed-by or Acked-by.
| Patch | Tim Landscheidt |
|---|---|
| 1/3 | |
| 2/3 | |
| 3/3 | Helped-by |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [PATCH v3 0/3] Add "git rebase --show-current-patch"
Compared to v2:
- the potential loss of errno before it's printed out in builtin/am.c is fixed.
- keep update_ref() in sequencer.c non-fatal like this rest
- rename ORIG_COMMIT to REBASE_HEAD
Interdiff:
Documentation/git-rebase.txt +1 -1
@@ -253,7 +253,7 @@ leave out at most one of A and B, in which case it defaults to HEAD. --show-current-patch:: Show the current patch in an interactive rebase or when rebase is stopped because of conflicts. This is the equivalent of - `git show ORIG_COMMIT`. + `git show REBASE_HEAD`. -m:: --merge::
builtin/am.c +8 -7
@@ -1011,7 +1011,7 @@ static void am_setup(struct am_state *state, enum patch_format patch_format,if (mkdir (state->dir,0777 ) <0 && errno !=EEXIST )die_errno (_ ("failed to create directory '%s'" ), state->dir); -delete_ref (NULL ,"ORIG_COMMIT" ,NULL ,REF_NO_DEREF ); +delete_ref (NULL ,"REBASE_HEAD" ,NULL ,REF_NO_DEREF );if (split_mail (state, patch_format, paths, keep_cr) <0 ) {am_destroy (state);
@@ -1111,7 +1111,7 @@ static void am_next(struct am_state *state)oidclr (&state->orig_commit);unlink (am_path (state,"original-commit" )); -delete_ref (NULL ,"ORIG_COMMIT" ,NULL ,REF_NO_DEREF ); +delete_ref (NULL ,"REBASE_HEAD" ,NULL ,REF_NO_DEREF );if (!get_oid ("HEAD" , &head))write_state_text (state,"abort-safety" ,oid_to_hex (&head));
@@ -1443,8 +1443,8 @@ static int parse_mail_rebase(struct am_state *state, const char *mail)oidcpy (&state->orig_commit, &commit_oid);write_state_text (state,"original-commit" ,oid_to_hex (&commit_oid)); -update_ref ("am" ,"ORIG_COMMIT" , &commit_oid, -NULL ,0 ,UPDATE_REFS_DIE_ON_ERR ); +update_ref ("am" ,"REBASE_HEAD" , &commit_oid, +NULL ,REF_NO_DEREF ,UPDATE_REFS_DIE_ON_ERR );return 0 ; }
@@ -2127,6 +2127,7 @@ static void am_abort(struct am_state *state)static int show_patch (struct am_state *state) {struct strbuf sb =STRBUF_INIT ; +const char *patch_path;int len;if (!is_null_oid (&state->orig_commit)) {
@@ -2140,10 +2141,10 @@ static int show_patch(struct am_state *state)return ret; } - len =strbuf_read_file (&sb,am_path (state,msgnum (state)),0 ); + patch_path =am_path (state,msgnum (state)); + len =strbuf_read_file (&sb, patch_path,0 );if (len <0 ) -die_errno (_ ("failed to read '%s'" ), -am_path (state,msgnum (state))); +die_errno (_ ("failed to read '%s'" ), patch_path);setup_pager ();write_in_full (1 , sb.buf, sb.len);
contrib/completion/git-completion.bash +1 -1
@@ -439,7 +439,7 @@ __git_refs () track="" ;; *) - for i in HEAD FETCH_HEAD ORIG_HEAD MERGE_HEAD ORIG_COMMIT; do + for i in HEAD FETCH_HEAD ORIG_HEAD MERGE_HEAD REBASE_HEAD; do case "$i" in $match*) if [ -e "$dir/$i" ]; then
git-rebase--interactive.sh +4 -4
@@ -199,14 +199,14 @@ make_patch () { die_with_patch () { echo "$1" > "$state_dir"/stopped-sha - git update-ref ORIG_COMMIT "$1" + git update-ref REBASE_HEAD "$1" make_patch "$1" die "$2" } exit_with_patch () { echo "$1" > "$state_dir"/stopped-sha - git update-ref ORIG_COMMIT "$1" + git update-ref REBASE_HEAD "$1" make_patch $1 git rev-parse --verify HEAD > "$amend" gpg_sign_opt_quoted=${gpg_sign_opt:+$(git rev-parse --sq-quote "$gpg_sign_opt")}
@@ -843,7 +843,7 @@ To continue rebase after editing, run: exit ;; show-current-patch) - exec git show ORIG_COMMIT -- + exec git show REBASE_HEAD -- ;; esac
@@ -860,7 +860,7 @@ fi orig_head=$(git rev-parse --verify HEAD) || die "$(gettext "No HEAD?")" mkdir -p "$state_dir" || die "$(eval_gettext "Could not create temporary \$state_dir")" -rm -f "$(git rev-parse --git-path ORIG_COMMIT)" +rm -f "$(git rev-parse --git-path REBASE_HEAD)" : > "$state_dir"/interactive || die "$(gettext "Could not mark as interactive")" write_basic_state
git-rebase--merge.sh +3 -3
@@ -57,7 +57,7 @@ call_merge () { echo "$msgnum" >"$state_dir/msgnum" cmt="$(cat "$state_dir/cmt.$msgnum")" echo "$cmt" > "$state_dir/current" - git update-ref ORIG_COMMIT "$cmt" + git update-ref REBASE_HEAD "$cmt" hd=$(git rev-parse --verify HEAD) cmt_name=$(git symbolic-ref HEAD 2> /dev/null || echo HEAD) eval GITHEAD_$cmt='"${cmt_name##refs/heads/}~$(($end - $msgnum))"'
@@ -139,14 +139,14 @@ skip) return ;; show-current-patch) - exec git show ORIG_COMMIT -- + exec git show REBASE_HEAD -- ;; esac mkdir -p "$state_dir" echo "$onto_name" > "$state_dir/onto_name" write_basic_state -rm -f "$(git rev-parse --git-path ORIG_COMMIT)" +rm -f "$(git rev-parse --git-path REBASE_HEAD)" msgnum=0 for cmt in $(git rev-list --reverse --no-merges "$revisions")
git-rebase.sh +1 -1
@@ -182,7 +182,7 @@ You can run "git stash pop" or "git stash drop" at any time. } finish_rebase () { - rm -f "$(git rev-parse --git-path ORIG_COMMIT)" + rm -f "$(git rev-parse --git-path REBASE_HEAD)" apply_autostash && { git gc --auto || true; } && rm -rf "$state_dir"
sequencer.c +4 -3
@@ -1792,8 +1792,9 @@ static int make_patch(struct commit *commit, struct replay_opts *opts) p =short_commit_name (commit);if (write_message (p,strlen (p),rebase_path_stopped_sha (),1 ) <0 )return -1 ; -update_ref ("rebase" ,"ORIG_COMMIT" , &commit->object.oid, -NULL ,0 ,UPDATE_REFS_DIE_ON_ERR ); +if (update_ref ("rebase" ,"REBASE_HEAD" , &commit->object.oid, +NULL ,REF_NO_DEREF ,UPDATE_REFS_MSG_ON_ERR )) + res |=error (_ ("could not update %s" ),"REBASE_HEAD" );strbuf_addf (&buf,"%s/patch" ,get_dir (opts));memset (&log_tree_opt,0 ,sizeof (log_tree_opt));
@@ -2045,7 +2046,7 @@ static int pick_commits(struct todo_list *todo_list, struct replay_opts *opts)unlink (rebase_path_author_script ());unlink (rebase_path_stopped_sha ());unlink (rebase_path_amend ()); -delete_ref (NULL ,"ORIG_COMMIT" ,NULL ,REF_NO_DEREF ); +delete_ref (NULL ,"REBASE_HEAD" ,NULL ,REF_NO_DEREF ); }if (item->command <=TODO_SQUASH ) {if (is_rebase_i (opts))
t/t3400-rebase.sh +2 -2
@@ -306,8 +306,8 @@ test_expect_success 'rebase--merge.sh and --show-current-patch' ' test_must_fail git rebase --merge --onto init HEAD^ && git rebase --show-current-patch >actual.patch && GIT_TRACE=1 git rebase --show-current-patch >/dev/null 2>stderr && - grep "show.*ORIG_COMMIT" stderr && - test "$(git rev-parse ORIG_COMMIT)" = "$(git rev-parse two)" + grep "show.*REBASE_HEAD" stderr && + test "$(git rev-parse REBASE_HEAD)" = "$(git rev-parse two)" ) '
t/t3404-rebase-interactive.sh +2 -2
@@ -227,10 +227,10 @@ test_expect_success 'stop on conflicting pick' ' test_expect_success 'show conflicted patch' ' GIT_TRACE=1 git rebase --show-current-patch >/dev/null 2>stderr && - grep "show.*ORIG_COMMIT" stderr && + grep "show.*REBASE_HEAD" stderr && # the original stopped-sha1 is abbreviated stopped_sha1="$(git rev-parse $(cat ".git/rebase-merge/stopped-sha"))" && - test "$(git rev-parse ORIG_COMMIT)" = "$stopped_sha1" + test "$(git rev-parse REBASE_HEAD)" = "$stopped_sha1" ' test_expect_success 'abort' '
Signature · 1 line
2.16.1.399.g632f88eed1