Skip to content

IB/hfi1, core: Driver updates for 1/26/2018

Dennis Dalessandro linux-rdma 2 versions In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest16 patches 8 repliesIn review
  2. v116 patches 10 repliesSuperseded

Changes in v2 from the cover letter

----------------
Moved kobj get in patch 6, also changed patch one-line desc Moved iWARP undef AH to be 0 instead of 3

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/16IB/hfi1: Do not override given pcie_pset valuedrivers/infiniband/hw/hfi1/pcie.c+12 -110 replies
2/16IB/hfi1: Fix for early release of sdma contextdrivers/infiniband/hw/hfi1/init.c drivers/infiniband/hw/hfi1/sdma.c drivers/infiniband/hw/hfi1/sdma.h+9 -60 replies
3/16IB/hfi1: Remove dependence on qp->s_hdrwordsdrivers/infiniband/hw/hfi1/iowait.h drivers/infiniband/hw/hfi1/qp.c drivers/infiniband/hw/hfi1/qp.h +7 more+61 -590 replies
4/16IB/hfi1: Remove blind constants from 16B updatedrivers/infiniband/hw/hfi1/driver.c drivers/infiniband/hw/hfi1/ruc.c drivers/infiniband/hw/hfi1/ud.c +1 more+25 -140 replies
5/16IB/hfi1: Convert PortXmitWait/PortVLXmitWait counters to flit timesdrivers/infiniband/hw/hfi1/chip.c drivers/infiniband/hw/hfi1/chip.h drivers/infiniband/hw/hfi1/hfi.h +3 more+239 -190 replies
6/16IB/hfi1: Fix for potential refcount leak in hfi1_open_file()drivers/infiniband/hw/hfi1/file_ops.c+1 -31 reply
7/16IB/hfi1: Show fault stats in both TX and RX directionsdrivers/infiniband/hw/hfi1/debugfs.c+8 -10 replies
8/16IB/hfi1: Prevent LNI hang when LCB can't obtain lanesdrivers/infiniband/hw/hfi1/chip.c drivers/infiniband/hw/hfi1/chip.h drivers/infiniband/hw/hfi1/chip_registers.h+53 -200 replies
9/16IB/hfi1: Compute BTH only for RDMA_WRITE_LAST/SEND_LAST packetdrivers/infiniband/hw/hfi1/rc.c drivers/infiniband/hw/hfi1/uc.c drivers/infiniband/hw/hfi1/ud.c +4 more+10 -120 replies
10/16IB/hfi1: Optimize packet type comparison using 9B and bypass code pathsdrivers/infiniband/hw/hfi1/driver.c drivers/infiniband/hw/hfi1/hfi.h drivers/infiniband/hw/hfi1/ruc.c +2 more+18 -130 replies
11/16IB/hfi1: Look up ibport using a pointer in receive pathdrivers/infiniband/hw/hfi1/driver.c drivers/infiniband/hw/hfi1/rc.c drivers/infiniband/hw/hfi1/verbs.h+30 -230 replies
12/16IB/hfi1: Remove unnecessary fecn and becn fieldsdrivers/infiniband/hw/hfi1/driver.c drivers/infiniband/hw/hfi1/hfi.h drivers/infiniband/hw/hfi1/rc.c +4 more+24 -360 replies
13/16IB/hfi1: Optimize process_receive_ib()drivers/infiniband/hw/hfi1/driver.c drivers/infiniband/hw/hfi1/trace_rx.h+17 -320 replies
14/16IB/hfi1: Re-order IRQ cleanup to address driver cleanup racedrivers/infiniband/hw/hfi1/chip.c drivers/infiniband/hw/hfi1/hfi.h drivers/infiniband/hw/hfi1/init.c+16 -70 replies
15/16IB/core: Map iWarp AH type to undefined in rdma_ah_find_typeinclude/rdma/ib_verbs.h+10 -27 replies
16/16IB/ipoib: Fix for potential no-carrier statedrivers/infiniband/ulp/ipoib/ipoib_main.c+3 -00 replies

Reviews trailers per patch

All 16 patches have a Reviewed-by or Acked-by.

PatchDennis DalessandroMike MarciniszynMichael J RuhlDon HiattAlex EstrinPatel Jay PIra WeinyShiraz Saleem
1/16R-b
2/16R-b R-b
3/16R-b
4/16R-b
5/16R-b
6/16R-b
7/16R-b R-b
8/16R-b R-b
9/16R-b
10/16R-b R-b
11/16R-b
12/16R-b
13/16R-b R-b
14/16R-b R-b R-b
15/16R-b R-b
16/16R-b R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 8 reviewers.

Read the v2 thread

Cover letter [PATCH for-next v2 00/16] IB/hfi1, core: Driver updates for 1/26/2018

Hi Jason and Doug,

For the most part this is the usual sort of fixes and clean ups with some things that help optmize performance thrown in. There are three patches that may be of a broader interest. There is a change to core header files for iWARP AH as well as a fix to ipoib for a scenario where we can wind up in no-carrier state.

The other patch by Mike R comes out of the discussion [1] from a previous submission.

As always my GitHub had these in-tree for context:
https://github.com/ddalessa/kernel/tree/for-4.16

[1] https://marc.info/?l=linux-rdma&m=151394843919393&w=2

---

changes since v1
----------------
Moved kobj get in patch 6, also changed patch one-line desc Moved iWARP undef AH to be 0 instead of 3

---

Alex Estrin (3):
IB/hfi1: Fix for early release of sdma context IB/hfi1: Fix for potential refcount leak in hfi1_open_file() IB/ipoib: Fix for potential no-carrier state

Bartlomiej Dudek (1):
IB/hfi1: Do not override given pcie_pset value

Don Hiatt (1):
IB/core: Map iWarp AH type to undefined in rdma_ah_find_type

Kamenee Arumugam (1):
IB/hfi1: Convert PortXmitWait/PortVLXmitWait counters to flit times

Michael J. Ruhl (1):
IB/hfi1: Re-order IRQ cleanup to address driver cleanup race

Mike Marciniszyn (1):
IB/hfi1: Remove blind constants from 16B update

Mitko Haralanov (2):
IB/hfi1: Remove dependence on qp->s_hdrwords IB/hfi1: Show fault stats in both TX and RX directions

Sebastian Sanchez (6):
IB/hfi1: Prevent LNI hang when LCB can't obtain lanes IB/hfi1: Compute BTH only for RDMA_WRITE_LAST/SEND_LAST packet IB/hfi1: Optimize packet type comparison using 9B and bypass code paths IB/hfi1: Look up ibport using a pointer in receive path IB/hfi1: Remove unnecessary fecn and becn fields
IB/hfi1: Optimize process_receive_ib()

 drivers/infiniband/hw/hfi1/chip.c           |  133 +++++++++++++++++++++------
 drivers/infiniband/hw/hfi1/chip.h           |   19 +++-
 drivers/infiniband/hw/hfi1/chip_registers.h |    7 +
 drivers/infiniband/hw/hfi1/debugfs.c        |    9 ++
 drivers/infiniband/hw/hfi1/driver.c         |   49 +++++-----
 drivers/infiniband/hw/hfi1/file_ops.c       |    4 -
 drivers/infiniband/hw/hfi1/hfi.h            |   26 +++--
 drivers/infiniband/hw/hfi1/init.c           |   14 +++
 drivers/infiniband/hw/hfi1/iowait.h         |    9 ++
 drivers/infiniband/hw/hfi1/mad.c            |  127 ++++++++++++++++++++++++--
 drivers/infiniband/hw/hfi1/mad.h            |   47 +++++++++-
 drivers/infiniband/hw/hfi1/pcie.c           |   23 ++---
 drivers/infiniband/hw/hfi1/qp.c             |    4 -
 drivers/infiniband/hw/hfi1/qp.h             |   13 +++
 drivers/infiniband/hw/hfi1/rc.c             |   51 +++++-----
 drivers/infiniband/hw/hfi1/ruc.c            |   47 +++-------
 drivers/infiniband/hw/hfi1/sdma.c           |   13 +--
 drivers/infiniband/hw/hfi1/sdma.h           |    1 
 drivers/infiniband/hw/hfi1/trace.c          |    8 +-
 drivers/infiniband/hw/hfi1/trace_ibhdrs.h   |   16 ++-
 drivers/infiniband/hw/hfi1/trace_rx.h       |   28 ++----
 drivers/infiniband/hw/hfi1/uc.c             |    9 --
 drivers/infiniband/hw/hfi1/ud.c             |   39 ++++----
 drivers/infiniband/hw/hfi1/verbs.c          |   10 +-
 drivers/infiniband/hw/hfi1/verbs.h          |   24 ++---
 drivers/infiniband/hw/hfi1/verbs_txreq.h    |    7 +
 drivers/infiniband/hw/qib/qib_rc.c          |    3 -
 drivers/infiniband/hw/qib/qib_uc.c          |    3 -
 drivers/infiniband/hw/qib/qib_ud.c          |    3 -
 drivers/infiniband/ulp/ipoib/ipoib_main.c   |    3 +
 include/rdma/ib_hdrs.h                      |   19 +++-
 include/rdma/ib_verbs.h                     |   12 ++
 32 files changed, 529 insertions(+), 251 deletions(-)

--
-Denny
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html