fix Python code style
Get series with b4
b4 am [email protected]Versions newest first
- v1 Latest3 of 14 patches 0 repliesNew
3 of 14 patches are in this archive. The cover letter announces 14.
Patches in v1 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 8/14 | diffconfig: fix code style | +0 | 5 replies | |
| 9/14 | genrandconfig: fix code style | +0 | 1 reply | |
| 12/14 | size-stats-compare: fix code style | +0 | 4 replies |
Reviews trailers per patch
No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.
Cover letter [Buildroot] [PATCH 00/14] fix Python code style
Hello,
Thanks for working on this. I've applied a number of patches, but not all of them. I'll say below which ones have been applied, and I will comment on the patches themselves for those that have not been applied.
Quoted 15 lines · Ricardo Martincoski
I am ignoring this script for now:
support/scripts/xorg-release
I opened a thread about it:
http://lists.busybox.net/pipermail/buildroot/2018-January/211557.htmlThe first 12 patches fix each script.
I tried to do the minimum to accomplish the task avoiding any unrelated refactoring, what IMO brings these advantages:
- small chance of introducing regressions;
- easy code review;
- less testing effort.
Most of the commit messages are terse as the changes I introduced are minimal. If I missed to explain any change that is not obvious, please ask me on the review.
Quoted 8 lines
Patch 13 adds support to install flake8 on the fly to the Docker image, needed by the next patch.
Patch 14 creates a job in gitlab to run flake8:
https://gitlab.com/RicardoMartincoski/buildroot/-/jobs/48876752And here a complete run on gitlab using current Docker image:
https://gitlab.com/RicardoMartincoski/buildroot/pipelines/16432662
One rule that I find a bit silly in flake8 checks is "every function must be separated from the previous function with two blank lines". But OK, if flake8 wants that, and Python developers like it, why not.
Quoted 8 lines
Ricardo Martincoski (14):
graph-depends: fix code style
check-uniq-files: fix code style
graph-build-time: fix code style
pycompile: fix code style
size-stats: fix code style
testing/tests/boot/test_atf: fix code style
check-package: fix code style
All those applied.
Quoted 1 line
diffconfig: fix code style
Not applied.
Quoted 1 line
genrandconfig: fix code style
Not applied.
Quoted 2 lines
get-developers: fix code style
scanpypi: fix code style
Both of these applied.
Quoted 1 line
size-stats-compare: fix code style
Not applied.
Quoted 2 lines
support/dockerfile: allow to install packages
.gitlab-ci.yml: check flake8
And of course, I haven't applied those, because not all problems have been fixed yet, due to me not applying all patches.
Thanks!
Thomas
Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com