PCI endpoint 64-bit BAR fixes
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v5 Latest12 patches 24 repliesIn review
- v45 patches 14 repliesSuperseded
- v33 patches 3 repliesSuperseded
Earlier versions · 2
| Version | Posted | Patches | Replies | Status |
|---|---|---|---|---|
| v2 | 3 patches | 7 replies | Superseded | |
| v1 | 3 patches | 5 replies | Superseded |
Patches in v5 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/12 | PCI: endpoint: BAR width should not depend on sizeof dma_addr_tdrivers/ | +7 | 1 reply | |
| 2/12 | PCI: endpoint: Simplify epc->ops->set_bar()/pci_epc_set_bar()drivers/ drivers/ drivers/ +4 more | +25 | 2 replies | |
| 3/12 | PCI: endpoint: Setting BAR_5 to 64-bits wide is invaliddrivers/ | +3 | 1 reply | |
| 4/12 | PCI: endpoint: Setting 64-bit/prefetch bit is invalid when IO is setdrivers/ | +4 | 1 reply | |
| 5/12 | PCI: endpoint: Setting a BAR size > 4 GB is invalid if 64-bit flag is not setdrivers/ | +3 | 1 reply | |
| 6/12 | PCI: designware-ep: Make dw_pcie_ep_set_bar() handle 64-bit BARs properlydrivers/ | +9 | 6 replies | |
| 7/12 | PCI: cadence: Set PCI_BASE_ADDRESS_MEM_TYPE_64 if a 64-bit BAR was set-updrivers/ | +3 | 3 replies | |
| 8/12 | PCI: endpoint: Handle 64-bit BARs properlydrivers/ | +7 | 1 reply | |
| 9/12 | PCI: endpoint: Make epc->ops->clear_bar()/pci_epc_clear_bar() take struct *epf_bardrivers/ drivers/ drivers/ +2 more | +23 | 3 replies | |
| 10/12 | PCI: endpoint: Make sure that BAR_5 does not have 64-bit flag set when clearingdrivers/ | +3 | 1 reply | |
| 11/12 | PCI: designware-ep: Make dw_pcie_ep_reset_bar() handle 64-bit BARs properlydrivers/ | +4 | 2 replies | |
| 12/12 | misc: pci_endpoint_test: Handle 64-bit BARs properlydrivers/ | +7 | 0 replies |
Reviews trailers per patch
All 12 patches have a Reviewed-by or Acked-by.
| Patch | Kishon Vijay Abraham I | Gustavo Pimentel | Alan Douglas |
|---|---|---|---|
| Series | T-b | ||
| 1/12 | A-b | ||
| 2/12 | A-b | R-b | |
| 3/12 | A-b | ||
| 4/12 | A-b | ||
| 5/12 | A-b | ||
| 6/12 | R-b | ||
| 7/12 | A-b A-b | ||
| 8/12 | A-b | ||
| 9/12 | R-b | ||
| 10/12 | A-b | ||
| 11/12 | A-b | R-b | |
| 12/12 | A-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.
Cover letter [PATCH v5 00/12] PCI endpoint 64-bit BAR fixes
PCI endpoint fixes to improve the way 64-bit BARs are handled.
There are still future improvements that could be made:
pci-epf-test.c always allocates space for 6 BARs, even when using 64-bit BARs (which really only requires us to allocate 3 BARs).
pcitest.sh will print "NOT OKAY" for BAR1, BAR3, and BAR5 when using 64-bit BARs. This could probably be improved to say something like "N/A (64-bit BAR)".
Niklas Cassel (12):
PCI: endpoint: BAR width should not depend on sizeof dma_addr_t
PCI: endpoint: Simplify epc->ops->set_bar()/pci_epc_set_bar()
PCI: endpoint: Setting BAR_5 to 64-bits wide is invalid
PCI: endpoint: Setting 64-bit/prefetch bit is invalid when IO is set
PCI: endpoint: Setting a BAR size > 4 GB is invalid if 64-bit flag is
not set
PCI: designware-ep: Make dw_pcie_ep_set_bar() handle 64-bit BARs
properly
PCI: cadence: Set PCI_BASE_ADDRESS_MEM_TYPE_64 if a 64-bit BAR was
set-up
PCI: endpoint: Handle 64-bit BARs properly
PCI: endpoint: Make epc->ops->clear_bar()/pci_epc_clear_bar() take
struct *epf_bar
PCI: endpoint: Make sure that BAR_5 does not have 64-bit flag set when
clearing
PCI: designware-ep: Make dw_pcie_ep_reset_bar() handle 64-bit BARs
properly
misc: pci_endpoint_test: Handle 64-bit BARs properly
drivers/misc/pci_endpoint_test.c | 12 +++++---- drivers/pci/cadence/pcie-cadence-ep.c | 15 ++++++++--- drivers/pci/dwc/pcie-designware-ep.c | 36 +++++++++++++++++++++------ drivers/pci/endpoint/functions/pci-epf-test.c | 28 +++++++++++++-------- drivers/pci/endpoint/pci-epc-core.c | 32 +++++++++++++++--------- drivers/pci/endpoint/pci-epf-core.c | 4 +++ include/linux/pci-epc.h | 11 ++++---- include/linux/pci-epf.h | 2 ++ 8 files changed, 95 insertions(+), 45 deletions(-)
Signature · 1 line
2.14.2