Skip to content

PCI endpoint 64-bit BAR fixes

Niklas Cassel linux-pci lkml 5 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v5 Latest12 patches 24 repliesIn review
  2. v45 patches 14 repliesSuperseded
  3. v33 patches 3 repliesSuperseded
Earlier versions · 2
VersionPostedPatchesRepliesStatus
v23 patches7 repliesSuperseded
v13 patches5 repliesSuperseded

Patches in v5 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/12PCI: endpoint: BAR width should not depend on sizeof dma_addr_tdrivers/pci/endpoint/functions/pci-epf-test.c+7 -51 reply
2/12PCI: endpoint: Simplify epc->ops->set_bar()/pci_epc_set_bar()drivers/pci/cadence/pcie-cadence-ep.c drivers/pci/dwc/pcie-designware-ep.c drivers/pci/endpoint/functions/pci-epf-test.c +4 more+25 -222 replies
3/12PCI: endpoint: Setting BAR_5 to 64-bits wide is invaliddrivers/pci/endpoint/pci-epc-core.c+3 -11 reply
4/12PCI: endpoint: Setting 64-bit/prefetch bit is invalid when IO is setdrivers/pci/endpoint/pci-epc-core.c+4 -11 reply
5/12PCI: endpoint: Setting a BAR size > 4 GB is invalid if 64-bit flag is not setdrivers/pci/endpoint/pci-epc-core.c+3 -11 reply
6/12PCI: designware-ep: Make dw_pcie_ep_set_bar() handle 64-bit BARs properlydrivers/pci/dwc/pcie-designware-ep.c+9 -26 replies
7/12PCI: cadence: Set PCI_BASE_ADDRESS_MEM_TYPE_64 if a 64-bit BAR was set-updrivers/pci/cadence/pcie-cadence-ep.c+3 -03 replies
8/12PCI: endpoint: Handle 64-bit BARs properlydrivers/pci/endpoint/functions/pci-epf-test.c+7 -01 reply
9/12PCI: endpoint: Make epc->ops->clear_bar()/pci_epc_clear_bar() take struct *epf_bardrivers/pci/cadence/pcie-cadence-ep.c drivers/pci/dwc/pcie-designware-ep.c drivers/pci/endpoint/functions/pci-epf-test.c +2 more+23 -103 replies
10/12PCI: endpoint: Make sure that BAR_5 does not have 64-bit flag set when clearingdrivers/pci/endpoint/pci-epc-core.c+3 -11 reply
11/12PCI: designware-ep: Make dw_pcie_ep_reset_bar() handle 64-bit BARs properlydrivers/pci/dwc/pcie-designware-ep.c+4 -02 replies
12/12misc: pci_endpoint_test: Handle 64-bit BARs properlydrivers/misc/pci_endpoint_test.c+7 -50 replies

Reviews trailers per patch

All 12 patches have a Reviewed-by or Acked-by.

PatchKishon Vijay Abraham IGustavo PimentelAlan Douglas
SeriesT-b
1/12A-b
2/12A-b R-b
3/12A-b
4/12A-b
5/12A-b
6/12R-b
7/12A-b A-b
8/12A-b
9/12R-b
10/12A-b
11/12A-b R-b
12/12A-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.

Read the v5 thread

Cover letter [PATCH v5 00/12] PCI endpoint 64-bit BAR fixes

PCI endpoint fixes to improve the way 64-bit BARs are handled.

There are still future improvements that could be made:

pci-epf-test.c always allocates space for 6 BARs, even when using 64-bit BARs (which really only requires us to allocate 3 BARs).

pcitest.sh will print "NOT OKAY" for BAR1, BAR3, and BAR5 when using 64-bit BARs. This could probably be improved to say something like "N/A (64-bit BAR)".

Niklas Cassel (12):
PCI: endpoint: BAR width should not depend on sizeof dma_addr_t
PCI: endpoint: Simplify epc->ops->set_bar()/pci_epc_set_bar()
PCI: endpoint: Setting BAR_5 to 64-bits wide is invalid
PCI: endpoint: Setting 64-bit/prefetch bit is invalid when IO is set
PCI: endpoint: Setting a BAR size > 4 GB is invalid if 64-bit flag is
not set
PCI: designware-ep: Make dw_pcie_ep_set_bar() handle 64-bit BARs
properly
PCI: cadence: Set PCI_BASE_ADDRESS_MEM_TYPE_64 if a 64-bit BAR was
set-up
PCI: endpoint: Handle 64-bit BARs properly
PCI: endpoint: Make epc->ops->clear_bar()/pci_epc_clear_bar() take
struct *epf_bar
PCI: endpoint: Make sure that BAR_5 does not have 64-bit flag set when
clearing
PCI: designware-ep: Make dw_pcie_ep_reset_bar() handle 64-bit BARs
properly
misc: pci_endpoint_test: Handle 64-bit BARs properly

 drivers/misc/pci_endpoint_test.c              | 12 +++++----
 drivers/pci/cadence/pcie-cadence-ep.c         | 15 ++++++++---
 drivers/pci/dwc/pcie-designware-ep.c          | 36 +++++++++++++++++++++------
 drivers/pci/endpoint/functions/pci-epf-test.c | 28 +++++++++++++--------
 drivers/pci/endpoint/pci-epc-core.c           | 32 +++++++++++++++---------
 drivers/pci/endpoint/pci-epf-core.c           |  4 +++
 include/linux/pci-epc.h                       | 11 ++++----
 include/linux/pci-epf.h                       |  2 ++
 8 files changed, 95 insertions(+), 45 deletions(-)
Signature · 1 line
2.14.2