RFC iproute printing enhancements
Get series with b4
b4 am [email protected]Versions newest first
- v1 RFC Latest16 patches 3 repliesIn review
Patches in v1 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/16 | iproute: refactor printing flagsip/ | +22 | 0 replies | |
| 2/16 | iproute: make printing icmpv6 a functionip/ | +21 | 0 replies | |
| 3/16 | iproute: make printing IPv4 cache flags a functionip/ | +37 | 0 replies | |
| 4/16 | iproute: refactor cacheinfo printingip/ | +32 | 0 replies | |
| 5/16 | iproute: refactor metrics printip/ | +61 | 0 replies | |
| 6/16 | iproute: refactor printing flow infoip/ | +20 | 0 replies | |
| 7/16 | iproute2: refactor newdst, gateway and via printingip/ | +40 | 0 replies | |
| 8/16 | iproute: refactor multipath printip/ | +63 | 0 replies | |
| 9/16 | iproute: refactor printing of interfaceip/ | +11 | 0 replies | |
| 10/16 | iproute: whitespace fixesip/ | +13 | 0 replies | |
| 11/16 | iproute: don't do assignment in conditionip/ | +16 | 0 replies | |
| 12/16 | iproute: make flush a separate functionip/ | +64 | 0 replies | |
| 13/16 | iproute: implement JSON and color outputinclude/ ip/ | +259 | 0 replies | |
| 14/16 | json: make pretty printing optionalinclude/ include/ ip/ +2 more | +10 | 0 replies | |
| 15/16 | man: add documentation for json and pretty flagsip/ man/ man/ | +18 | 0 replies | |
| 16/16 | json: fix newline at end of arraylib/ lib/ | +5 | 0 replies |
Reviews trailers per patch
No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.
Cover letter [RFC iproute2-next 00/16] iproute printing enhancements
The first group of patches refactor the printout to breakup excessively long print_route function and the last few implement JSON and color output format for routes.
The one thing that maybe controversial is changing the default json output format to be compact. The value of JSON is for programattic output therefore pretty-printing should be an option.
One change I didn't make (but considered) is not calling fflush after every single entry. When dumping millions of routes, letting stdio buffer output would be a performance win.
Stephen Hemminger (16):
iproute: refactor printing flags
iproute: make printing icmpv6 a function
iproute: make printing IPv4 cache flags a function
iproute: refactor cacheinfo printing
iproute: refactor metrics print
iproute: refactor printing flow info
iproute2: refactor newdst, gateway and via printing
iproute: refactor multipath print
iproute: refactor printing of interface
iproute: whitespace fixes
iproute: don't do assignment in condition
iproute: make flush a separate function
iproute: implement JSON and color output
json: make pretty printing optional
man: add documentation for json and pretty flags
json: fix newline at end of array
include/json_print.h | 2 + include/utils.h | 4 + ip/ip.c | 7 +- ip/iproute.c | 943 ++++++++++++++++++++++++++++++--------------------- lib/json_print.c | 5 +- lib/json_writer.c | 5 + man/man8/ip.8 | 18 +- man/man8/tc.8 | 3 +- tc/tc.c | 3 + 9 files changed, 598 insertions(+), 392 deletions(-)
Signature · 1 line
2.15.1