Skip to content

Incremental rewrite of git-submodules

Prathamesh Chavan git 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest5 patches 3 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/5submodule foreach: correct '$path' in nested submodules from a subdirectorygit-submodule.sh t/t7407-submodule-foreach.sh+34 -33 replies
2/5submodule foreach: document '$sm_path' instead of '$path'Documentation/git-submodule.txt+6 -40 replies
3/5submodule foreach: clarify the '$toplevel' variable documentationDocumentation/git-submodule.txt+2 -10 replies
4/5submodule foreach: document variable '$displaypath'Documentation/git-submodule.txt t/t7407-submodule-foreach.sh+15 -130 replies
5/5submodule: port submodule subcommand 'foreach' from shell to Cbuiltin/submodule--helper.c git-submodule.sh+152 -380 replies

Reviews trailers per patch

None of the 5 patches has a Reviewed-by or Acked-by.

PatchBrandon WilliamsChristian CouderStefan Beller
1/5
2/5
3/5
4/5
5/5Helped-by Mentored-by Mentored-by

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.

Read the v1 thread

Cover letter [PATCH v1 0/5] Incremental rewrite of git-submodules

Following series of patches focuses on porting submodule subcommand git-foreach from shell to C.
An initial attempt for porting was introduced about 9 months back, and since then then patches have undergone many changes. Some of the notable discussion thread which I would like to point out is: [1] The previous version of this patch series which was floated is available at: [2].

The following changes were made to that:
* As it was observed in other submodule subcommand's ported function that the number of params increased a lot, the variables quiet and recursive, were replaced in the cb_foreach struct with a single unsigned integer variable called flags.

* To accomodate the possiblity of a direct call to the functions runcommand_in_submodule(), callback function runcommand_in_submodule_cb() was introduced.

[1]: https://public-inbox.org/git/[email protected]/T/#u
[2]: https://public-inbox.org/git/[email protected]/

As before you can find this series at:
https://github.com/pratham-pc/git/commits/patch-series-3

And its build report is available at:
https://travis-ci.org/pratham-pc/git/builds/
Branch: patch-series-3
Build #202

Prathamesh Chavan (5):
submodule foreach: correct '$path' in nested submodules from a
subdirectory
submodule foreach: document '$sm_path' instead of '$path' submodule foreach: clarify the '$toplevel' variable documentation submodule foreach: document variable '$displaypath'
submodule: port submodule subcommand 'foreach' from shell to C

 Documentation/git-submodule.txt |  15 ++--
 builtin/submodule--helper.c     | 151 ++++++++++++++++++++++++++++++++++++++++
 git-submodule.sh                |  40 +----------
 t/t7407-submodule-foreach.sh    |  38 +++++++++-
 4 files changed, 197 insertions(+), 47 deletions(-)
Signature · 1 line
2.15.1