block/iscsi: fix ioctl cancel use-after-free
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v2 Latest3 patches 8 repliesIn review
- v13 patches 1 replySuperseded
Changes in v2 from the cover letter
* It was unnecessary to avoid duplicate iscsi_schedule_bh() calls since this function already protects against duplicate calls internally [Stefan]
Patches in v2 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/3 | block/iscsi: drop unused IscsiAIOCB->buf fieldblock/ | +0 | 1 reply | |
| 2/3 | block/iscsi: take iscsilun->mutex in iscsi_timed_check_events()block/ | +4 | 1 reply | |
| 3/3 | block/iscsi: fix ioctl cancel use-after-freeblock/ | +18 | 4 replies |
Reviews trailers per patch
All 3 patches have a Reviewed-by or Acked-by.
| Patch | Paolo Bonzini | Felipe Franciosi | Sreejith Mohanan |
|---|---|---|---|
| 1/3 | R-b | ||
| 2/3 | R-b | ||
| 3/3 | R-b | T-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.
Cover letter [Qemu-devel] [PATCH v2 0/3] block/iscsi: fix ioctl cancel use-after-free
v2:
* It was unnecessary to avoid duplicate iscsi_schedule_bh() calls since this function already protects against duplicate calls internally [Stefan]
Patches 1 & 2 are cleanups.
Patch 3 fixes cancellation of ioctls. Felipe showed me a trace where an acb is cancelled and then completes twice. The second time around crashes QEMU.
Compile-tested only.
Felipe: Please let us know if this fixes the issue you are seeing. Thanks!
Stefan Hajnoczi (3):
block/iscsi: drop unused IscsiAIOCB->buf field block/iscsi: take iscsilun->mutex in iscsi_timed_check_events() block/iscsi: fix ioctl cancel use-after-free
block/iscsi.c | 33 ++++++++++++++++++++++----------- 1 file changed, 22 insertions(+), 11 deletions(-)
Signature · 1 line
2.14.3