vhost: input validation enhancements
Status from this message: Applied to dpdk-next-virtio.
Get series with b4
b4 am [email protected]Versions newest first
Patches in v1 Applied
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/8 | vhost: add security model documentation to vhost_user.clib/ | +17 | 5 replies | |
| 2/8 | vhost: avoid enum fields in VhostUserMsglib/ | +2 | 1 reply | |
| 3/8 | vhost: validate untrusted memory.nregions fieldlib/ | +6 | 0 replies | |
| 4/8 | vhost: clear out unused SCM_RIGHTS file descriptorslib/ | +7 | 0 replies | |
| 5/8 | vhost: reject invalid log base mmap_offset valueslib/ | +9 | 0 replies | |
| 6/8 | vhost: fix msg->payload union typo in vhost_user_set_vring_addr()lib/ | +1 | 0 replies | |
| 7/8 | vhost: validate virtqueue sizelib/ | +11 | 0 replies | |
| 8/8 | vhost: check for memory_size + mmap_offset overflowlib/ | +11 | 0 replies |
Reviews trailers per patch
1 of 8 patches has a Reviewed-by or Acked-by of their own; the series has one for all of them.
| Patch | Maxime Coquelin | John McNamara |
|---|---|---|
| Series | R-b | |
| 1/8 | A-b | |
| 2/8 | ||
| 3/8 | ||
| 4/8 | ||
| 5/8 | ||
| 6/8 | ||
| 7/8 | ||
| 8/8 |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [PATCH 0/8] vhost: input validation enhancements
This patch series addresses missing input validation that I came across when reviewing vhost_user.c.
The first patch explains the security model and the rest fixes places with missing checks.
Now is a good time to discuss the security model if anyone disagrees or has questions about what Patch 1 says.
Stefan Hajnoczi (8):
vhost: add security model documentation to vhost_user.c
vhost: avoid enum fields in VhostUserMsg
vhost: validate untrusted memory.nregions field
vhost: clear out unused SCM_RIGHTS file descriptors
vhost: reject invalid log base mmap_offset values
vhost: fix msg->payload union typo in vhost_user_set_vring_addr()
vhost: validate virtqueue size
vhost: check for memory_size + mmap_offset overflow
lib/librte_vhost/vhost_user.h | 4 +-- lib/librte_vhost/socket.c | 8 +++++- lib/librte_vhost/vhost_user.c | 57 +++++++++++++++++++++++++++++++++++++++++-- 3 files changed, 64 insertions(+), 5 deletions(-)
Signature · 1 line
2.14.3