Skip to content

tools/kvm_stat improvements

Stefan Raspl kvm 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest8 patches 5 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/8tools/kvm_stat: fix crash when filtering out all non-child trace eventstools/kvm/kvm_stat/kvm_stat+6 -00 replies
2/8tools/kvm_stat: print error on invalid regextools/kvm/kvm_stat/kvm_stat+3 -00 replies
3/8tools/kvm_stat: mark private methods as suchtools/kvm/kvm_stat/kvm_stat+66 -662 replies
4/8tools/kvm_stat: eliminate extra guest/pid selection dialogtools/kvm/kvm_stat/kvm_stat tools/kvm/kvm_stat/kvm_stat.txt+39 -750 replies
5/8tools/kvm_stat: cache compiled regular expressiontools/kvm/kvm_stat/kvm_stat+11 -70 replies
6/8tools/kvm_stat: separate drilldown and fields filteringtools/kvm/kvm_stat/kvm_stat+93 -392 replies
7/8tools/kvm_stat: group child events indented after parenttools/kvm/kvm_stat/kvm_stat+59 -300 replies
8/8tools/kvm_stat: print 'Total' line for multiple events onlytools/kvm/kvm_stat/kvm_stat+1 -10 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 0/8] tools/kvm_stat improvements

Some bugfixes (patches 1&2), simplifications (patch 4), plus rework that lays the basis for introducing a (hopefully) neater drilldown mode in patch 7.
Note that in absence of any knowledge of the interdependencies of the events in debugfs on other platforms like x86, this new 'functionality' was only added for S390 for now. Adding other platforms would be easy enough, though.
Furthermore note that the data passing between Providers and Stats is pretty much at its limit now - if we'd ever wanted to put in more attributes along with the event data passed from Providers to Stats, we should probably switch to passing more involved data structures with indicator flags, etc. Not sure if performance is a concern, but from a coding/maintaining point of view that's something we should consider in that case.

Stefan Raspl (8):
tools/kvm_stat: fix crash when filtering out all non-child trace
events
tools/kvm_stat: print error on invalid regex tools/kvm_stat: mark private methods as such tools/kvm_stat: eliminate extra guest/pid selection dialog tools/kvm_stat: cache compiled regular expression tools/kvm_stat: separate drilldown and fields filtering tools/kvm_stat: group child events indented after parent tools/kvm_stat: print 'Total' line for multiple events only

 tools/kvm/kvm_stat/kvm_stat     | 438 +++++++++++++++++++++++-----------------
 tools/kvm/kvm_stat/kvm_stat.txt |   4 +-
 2 files changed, 251 insertions(+), 191 deletions(-)
Signature · 1 line
2.13.5