Skip to content

RFC tracing: Fix bogus parsing of probes and set_ftrace_filter

Steven Rostedt lkml stable 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 RFC Latest6 patches 4 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/6ftrace: Remove incorrect setting of glob search fieldkernel/trace/ftrace.c+0 -12 replies
2/6tracing: Fix parsing of globs with a wildcard at the beginningkernel/trace/trace_events_filter.c+4 -51 reply
3/6selftests/ftrace: Have reset_ftrace_filter handle modulestools/testing/selftests/ftrace/test.d/functions+4 -30 replies
4/6selftests/ftrace: Have reset_ftrace_filter handle multiple instancestools/testing/selftests/ftrace/test.d/functions+3 -00 replies
5/6selftests/ftrace: Add some missing glob checkstools/testing/selftests/ftrace/test.d/ftrace/func-filter-glob.tc+6 -01 reply
6/6selftests/ftrace: Add more tests for removing of function probestools/testing/selftests/ftrace/test.d/ftrace/func_set_ftrace_file.tc+37 -00 replies

Reviews trailers per patch

3 of 6 patches have a Reviewed-by or Acked-by.

PatchAl ViroDmitry SafonovMasami Hiramatsu
1/6R-b R-b
2/6Suggsted-by R-b
3/6
4/6
5/6A-b
6/6

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.

Read the v1 thread

Cover letter [RFC][PATCH 0/6] tracing: Fix bogus parsing of probes and set_ftrace_filter

Al Viro pointed out a couple of bugs with the parsing of the removing of function probes and the parsing of set_ftrace_filter strings.

This patch series implements his suggested fixes and adds selftests that would have caught the bugs in the first place.

Steven Rostedt (VMware) (6):
ftrace: Remove incorrect setting of glob search field
tracing: Fix parsing of globs with a wildcard at the beginning selftests/ftrace: Have reset_ftrace_filter handle modules selftests/ftrace: Have reset_ftrace_filter handle multiple instances selftests/ftrace: Add some missing glob checks selftests/ftrace: Add more tests for removing of function probes

----

 kernel/trace/ftrace.c                              |  1 -
 kernel/trace/trace_events_filter.c                 |  9 +++---
 .../ftrace/test.d/ftrace/func-filter-glob.tc       |  6 ++++
 .../ftrace/test.d/ftrace/func_set_ftrace_file.tc   | 37 ++++++++++++++++++++++
 tools/testing/selftests/ftrace/test.d/functions    | 10 ++++--
 5 files changed, 54 insertions(+), 9 deletions(-)