Skip to content

media: v4l: Add support for the Cadence MIPI-CSI2 TX controller

Maxime Ripard linux-devicetree linux-media 10 versions – New

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v12 Latest4 patches 0 repliesNew
  2. v114 patches 6 repliesSuperseded
  3. v102 patches 1 replySuperseded
Earlier versions · 7
VersionPostedPatchesRepliesStatus
v9 posting 2/22 patches0 repliesSuperseded
v9 posting 1/22 patches0 repliesSuperseded
v82 patches5 repliesSuperseded
v72 patches3 repliesSuperseded
v62 patches2 repliesSuperseded
v52 patches6 repliesSuperseded
v32 patches6 repliesSuperseded

Changes in v12 from the cover letter

- Added Makefile license
- Added Benoit's Acked-by
- Ignored the CSI2-RX return code on stop, and just log an error instead

Patches in v12 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/4dt-bindings: media: Add Cadence MIPI-CSI2 RX Device Tree bindingsDocumentation/devicetree/bindings/media/cdns,csi2rx.txt+100 -00 replies
2/4v4l: cadence: Add Cadence MIPI-CSI2 RX driverMAINTAINERS drivers/media/platform/Kconfig drivers/media/platform/Makefile +3 more+533 -00 replies
3/4dt-bindings: media: Add Cadence MIPI-CSI2 TX Device Tree bindingsDocumentation/devicetree/bindings/media/cdns,csi2tx.txt+98 -00 replies
4/4v4l: cadence: Add Cadence MIPI-CSI2 TX driverdrivers/media/platform/cadence/Kconfig drivers/media/platform/cadence/Makefile drivers/media/platform/cadence/cdns-csi2tx.c+575 -00 replies

Reviews trailers per patch

All 4 patches have a Reviewed-by or Acked-by.

PatchRob HerringBenoit ParrotSakari AilusNiklas SöderlundLaurent Pinchart
1/4A-b A-b A-b R-b R-b
2/4A-b A-b R-b
3/4A-b A-b A-b R-b
4/4A-b A-b R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 5 reviewers.

Read the v12 thread

Cover letter [PATCH v12 0/4] media: v4l: Add support for the Cadence MIPI-CSI2 TX controller

Hi,

Here is a hopefully final attempt at supporting the MIPI-CSI2 RX and TX blocks from Cadence.

This is a merged serie of the CSI2-RX and CSI2-TX series I've been sending for a while now and gathered a significant amount of Reviewed-by/Acked-by. The merge has been done thanks to Sakari's suggestion to ease the merge and the dependency between the two drivers on the MAINTAINERS/Kconfig/Makefile sides.

The CSI2-RX has not received any comment on its previous iteration, and CSI2-TX received some minor comments from Sakari that have been fixed in this series. You can have a look at the Changelog below if needed.

The TX controller is able to receive 4 video streams and stream them over a MIPI-CSI2 link using up to 4 lanes. Those streams are basically the interfaces to controllers generating some video signals, like a camera or a pattern generator.

The RX controller is able to receive CSI data over up to 4 lanes, and split it to over 4 streams. Those streams are basically the interfaces to the video grabbers that will perform the capture.

TX is then able to map input streams to CSI2 virtual channels and datatypes dynamically. The streaming devices choose their virtual channels through an additional signal that is transparent to the CSI2-TX. The datatypes however are yet another additional input signal, and can be mapped to any CSI2 datatypes. RX can do the opposite, being able to take virtual channel / datatypes and route them to proper pixel interfaces on demand.

Since v4l2 doesn't really allow for that setup at the moment, this preliminary version is a rather dumb one in order to start the discussion on how to address this properly.

Let me know what you think!
Maxime

Changes from v11:
- Added Makefile license
- Added Benoit's Acked-by
- Ignored the CSI2-RX return code on stop, and just log an error instead

Changes from CSI2-TX v10:
- Reword the source pad exception comment
- Handle the V4L2_SUBDEV_FORMAT_TRY case for get_fmt / set_fmt

Maxime Ripard (4):
dt-bindings: media: Add Cadence MIPI-CSI2 RX Device Tree bindings
v4l: cadence: Add Cadence MIPI-CSI2 RX driver
dt-bindings: media: Add Cadence MIPI-CSI2 TX Device Tree bindings
v4l: cadence: Add Cadence MIPI-CSI2 TX driver

 .../devicetree/bindings/media/cdns,csi2rx.txt | 100 ++++
 .../devicetree/bindings/media/cdns,csi2tx.txt |  98 +++
 MAINTAINERS                                   |   7 +
 drivers/media/platform/Kconfig                |   1 +
 drivers/media/platform/Makefile               |   1 +
 drivers/media/platform/cadence/Kconfig        |  34 ++
 drivers/media/platform/cadence/Makefile       |   4 +
 drivers/media/platform/cadence/cdns-csi2rx.c  | 498 ++++++++++++++++
 drivers/media/platform/cadence/cdns-csi2tx.c  | 563 ++++++++++++++++++
 9 files changed, 1306 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/media/cdns,csi2rx.txt
 create mode 100644 Documentation/devicetree/bindings/media/cdns,csi2tx.txt
 create mode 100644 drivers/media/platform/cadence/Kconfig
 create mode 100644 drivers/media/platform/cadence/Makefile
 create mode 100644 drivers/media/platform/cadence/cdns-csi2rx.c
 create mode 100644 drivers/media/platform/cadence/cdns-csi2tx.c
Signature · 1 line
2.17.0