Skip to content

Some OMAP2+ legacy hwmod data cleanup

Suman Anna linux-arm-kernel linux-omap 1 version New

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest9 patches 0 repliesNew

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/9dmaengine: omap-dma: include header for bool typeinclude/linux/omap-dmaengine.h+2 -01 reply
1/9dmaengine: omap-dma: include header for bool type+0 -00 replies
2/9mmc: hsmmc_omap: include types.h and provide header inclusion guardinclude/linux/platform_data/hsmmc-omap.h+8 -01 reply
3/9ARM: OMAP2+: Cleanup omap_gpio_dev_attr usagearch/arm/mach-omap2/omap_hwmod_2430_data.c arch/arm/mach-omap2/omap_hwmod_2xxx_ipblock_data.c arch/arm/mach-omap2/omap_hwmod_33xx_43xx_common_data.h +10 more+0 -980 replies
4/9ARM: OMAP2+: Cleanup omap_i2c_dev_attr usagearch/arm/mach-omap2/i2c.h arch/arm/mach-omap2/omap_hwmod_2420_data.c arch/arm/mach-omap2/omap_hwmod_2430_data.c +5 more+0 -850 replies
5/9ARM: OMAP2+: Cleanup omap_timer_capability_dev_attr usagearch/arm/mach-omap2/omap_hwmod_2420_data.c arch/arm/mach-omap2/omap_hwmod_2430_data.c arch/arm/mach-omap2/omap_hwmod_2xxx_ipblock_data.c +6 more+0 -1240 replies
6/9ARM: OMAP2+: Cleanup omap2_spi_dev_attr and other legacy dataarch/arm/mach-omap2/omap_hwmod_2420_data.c arch/arm/mach-omap2/omap_hwmod_2430_data.c arch/arm/mach-omap2/omap_hwmod_2xxx_ipblock_data.c +10 more+0 -1490 replies
7/9ARM: OMAP2+: Cleanup omap_mcbsp_dev_attr and other legacy dataarch/arm/mach-omap2/omap_hwmod_2430_data.c arch/arm/mach-omap2/omap_hwmod_3xxx_data.c arch/arm/mach-omap2/omap_hwmod_44xx_data.c +3 more+0 -410 replies
8/9ARM: OMAP: Move plat/i2c.h into mach-omap1 folderarch/arm/mach-omap1/common.h arch/arm/mach-omap1/i2c.c arch/arm/mach-omap1/i2c.h +1 more+6 -120 replies
9/9ARM: OMAP2+: Remove unused gpio header file referencesarch/arm/mach-omap2/devices.c arch/arm/mach-omap2/hsmmc.c arch/arm/mach-omap2/msdi.c+1 -40 replies

Reviews trailers per patch

None of the 10 patches has a Reviewed-by or Acked-by.

PatchSuman Anna
1/9T-b
1/9T-b
2/9
3/9
4/9
5/9
6/9
7/9
8/9
9/9

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH 0/9] Some OMAP2+ legacy hwmod data cleanup

Hi Tony,

The following series cleans up some legacy dev_attr data associated with OMAP DMTimer, I2C, McBSP, McSPI and GPIO modules and removes roughly ~500 lines. Patches are based on v4.16-rc1. I have build tested for both omap2plus and omap1 defconfigs, and booted on a few OMAP4+ boards that I have on my desk.

Here is the patch summary:
1. First two patches fixes header inclusion in omap-dmaengine.h and hsmmc-omap.h as I am getting build errors on subsequent patches when I removed some of the platform_data header files.
2. Patches 3 through 7 remove the .dev_attr data for the above modules from various hwmod data files and some macros from McSPI & McBSP platform data header files
3. Patch 8 moves the plat-omap/include/plat/i2c.h into mach-omap1 folder as there is no common i2c code in plat-omap folder anymore.
4. Last patch is a minor cleanup of gpio headers from couple of files.

Some important notes/comments:
- The DMTimer patch cleanup will conflict with Keerthy's current dmtimer-> clocksource series, but ideally he wouldn't need to convert the plat/dmtimer.h into a clocksource header with the removal of the plat/dmtimer.h inclusion from the hwmod data files.
- I found some gaps w.r.t DMTimers on DM814x/DM816x platforms, and haven't fixed them. Both seems to have DMTimer1 through 8, but only DMTimers 1, 2 and 3 are defined in dm814x.dtsi, while dm816x.dtsi is missing DMTimer8. DMTimer3 hwmod is not in the dm814x hwmod list, while DMTimer8 is left out altogther. The timer capabilities are also different between the hwmod data files (lists always-on) which is missing from corresponding dts files. Not sure which one is correct.

This leaves the hsmmc-omap and omap-dma pieces still using the .dev_attr. The former is only used by one OMAP3 board, so can be cleaned up if we limit the init code just for that one board.

regards
Suman

Suman Anna (9):
dmaengine: omap-dma: include header for bool type
mmc: hsmmc_omap: include types.h and provide header inclusion guard
ARM: OMAP2+: Cleanup omap_gpio_dev_attr usage
ARM: OMAP2+: Cleanup omap_i2c_dev_attr usage
ARM: OMAP2+: Cleanup omap_timer_capability_dev_attr usage
ARM: OMAP2+: Cleanup omap2_spi_dev_attr and other legacy data
ARM: OMAP2+: Cleanup omap_mcbsp_dev_attr and other legacy data
ARM: OMAP: Move plat/i2c.h into mach-omap1 folder
ARM: OMAP2+: Remove unused gpio header file references

 arch/arm/mach-omap1/common.h                       |   3 +-
 arch/arm/mach-omap1/i2c.c                          |   2 -
 .../{plat-omap/include/plat => mach-omap1}/i2c.h   |   9 +-
 arch/arm/mach-omap2/devices.c                      |   2 +-
 arch/arm/mach-omap2/hsmmc.c                        |   2 -
 arch/arm/mach-omap2/i2c.h                          |  15 +--
 arch/arm/mach-omap2/msdi.c                         |   1 -
 arch/arm/mach-omap2/omap_hwmod_2420_data.c         |  11 --
 arch/arm/mach-omap2/omap_hwmod_2430_data.c         |  18 ----
 arch/arm/mach-omap2/omap_hwmod_2xxx_ipblock_data.c |  60 -----------
 .../mach-omap2/omap_hwmod_33xx_43xx_common_data.h  |   3 -
 .../mach-omap2/omap_hwmod_33xx_43xx_ipblock_data.c |  23 ----
 arch/arm/mach-omap2/omap_hwmod_33xx_data.c         |   4 -
 arch/arm/mach-omap2/omap_hwmod_3xxx_data.c         | 116 ---------------------
 arch/arm/mach-omap2/omap_hwmod_43xx_data.c         |   8 --
 arch/arm/mach-omap2/omap_hwmod_44xx_data.c         |  75 -------------
 arch/arm/mach-omap2/omap_hwmod_54xx_data.c         |  54 ----------
 arch/arm/mach-omap2/omap_hwmod_7xx_data.c          |  53 ----------
 arch/arm/mach-omap2/omap_hwmod_81xx_data.c         |  29 ------
 arch/arm/mach-omap2/omap_hwmod_common_data.h       |   1 -
 arch/arm/plat-omap/include/plat/dmtimer.h          |   4 -
 include/linux/omap-dmaengine.h                     |   2 +
 include/linux/platform_data/asoc-ti-mcbsp.h        |  12 ---
 include/linux/platform_data/gpio-omap.h            |   5 -
 include/linux/platform_data/hsmmc-omap.h           |   8 ++
 include/linux/platform_data/spi-omap2-mcspi.h      |   8 --
 26 files changed, 16 insertions(+), 512 deletions(-)
 rename arch/arm/{plat-omap/include/plat => mach-omap1}/i2c.h (90%)
Signature · 1 line
2.15.1