Some OMAP2+ legacy hwmod data cleanup
Get series with b4
b4 am [email protected]Versions newest first
- v1 Latest2 of 9 patches 0 repliesNew
2 of 9 patches are in this archive. The cover letter announces 9.
Patches in v1 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/9 | dmaengine: omap-dma: include header for bool typearch/ arch/ arch/ | +6 | 1 reply | |
| 2/9 | mmc: hsmmc_omap: include types.h and provide header inclusion guard | +0 | 0 replies |
Reviews trailers per patch
None of the 2 patches has a Reviewed-by or Acked-by.
| Patch | Suman Anna |
|---|---|
| 1/9 | T-b |
| 2/9 |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [PATCH 0/9] Some OMAP2+ legacy hwmod data cleanup
Quoted 7 lines · Suman Anna
Hi Tony,
The following series cleans up some legacy
dev_attrdata associated with OMAP DMTimer, I2C, McBSP, McSPI and GPIO modules and removes roughly ~500 lines. Patches are based on v4.16-rc1. I have build tested for both omap2plus and omap1 defconfigs, and booted on a few OMAP4+ boards that I have on my desk.
Hey that's great :)
Quoted 11 lines
Here is the patch summary:
1. First two patches fixes header inclusion inomap-dmaengine.handhsmmc-omap.has I am getting build errors on subsequent patches when I removed some of theplatform_dataheader files.
2. Patches 3 through 7 remove the .dev_attr data for the above modules from various hwmod data files and some macros from McSPI & McBSP platform data header files
3. Patch 8 moves theplat-omap/include/plat/i2c.hinto mach-omap1 folder as there is no common i2c code in plat-omap folder anymore.
4. Last patch is a minor cleanup of gpio headers from couple of files.
Quoted 5 lines
Some important notes/comments:
- The DMTimer patch cleanup will conflict with Keerthy's current dmtimer-> clocksource series, but ideally he wouldn't need to convert theplat/dmtimer.hinto a clocksource header with the removal of theplat/dmtimer.hinclusion from the hwmod data files.
OK. It seems that we should do the clean up first if it just means leaving out unused header files.
Quoted 7 lines
- I found some gaps w.r.t DMTimers on DM814x/DM816x platforms, and haven't fixed them. Both seems to have DMTimer1 through 8, but only DMTimers 1, 2 and 3 are defined in
dm814x.dtsi, whiledm816x.dtsiis missing DMTimer8. DMTimer3 hwmod is not in the dm814x hwmod list, while DMTimer8 is left out altogther. The timer capabilities are also different between the hwmod data files (lists always-on) which is missing from corresponding dts files. Not sure which one is correct.
OK we should fix them. The capabilities can be seen by looking at the hardware and clockdomains. The always-on timers are of sysc type 1 (ti,sysc-omap2-timer) and in a always on power domain. The others are of sysc type 2 (ti,sysc-omap4-timer). We should get warnings for those from ti,sysc driver eventually if they don't match :)
Quoted 3 lines
This leaves the hsmmc-omap and omap-dma pieces still using the .dev_attr. The former is only used by one OMAP3 board, so can be cleaned up if we limit the init code just for that one board.
I think Nikolaus had patches coming for removing the last user of mmc pdata?
I think all we need to do is have pandora_wl1251_init_card initialized in the MMC driver based on a compatible value..
Regards,
Tony