Skip to content

selftests: fib_tests: simplifications, verbosity and a race

David Ahern netdev 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest4 patches 1 replyIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/4selftests: fib_tests: simplify ip commands in a namespacetools/testing/selftests/net/fib_tests.sh+105 -1050 replies
2/4selftests: fib_tests: Make test results more verbosetools/testing/selftests/net/fib_tests.sh+135 -1130 replies
3/4selftests: fib_tests: Move admin of dummy0 to helperstools/testing/selftests/net/fib_tests.sh+34 -660 replies
4/4selftests: fib_tests: sleep after changing carriertools/testing/selftests/net/fib_tests.sh+1 -00 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH net-next 0/4] selftests: fib_tests: simplifications, verbosity and a race

Improve efficiency of fib_tests.sh and make the test result more verbose, from this summary:

$ fib_tests.sh is failing in a VM:
    $ fib_tests.sh
    Running netdev unregister tests
    PASS: unicast route test
    PASS: multipath route test
    Running netdev down tests
    PASS: unicast route test
    PASS: multipath route test
    Running netdev carrier change tests
    PASS: local route carrier test
    FAIL: unicast route carrier test

where a single entry actually corresponds to many checks to a much more verbse output that clarifies test cases:
$fib_tests.sh
Single path route carrier test
....
Carrier down
IPv4 fibmatch [ OK ]
IPv6 fibmatch [ OK ]
IPv4 linkdown flag set [FAIL]
IPv6 linkdown flag set [FAIL]
Second address added with carrier down
IPv4 fibmatch [ OK ]
IPv6 fibmatch [ OK ]
IPv4 linkdown flag set [FAIL]
IPv6 linkdown flag set [ OK ]

And then fix the race in changing carrier down on dummy device to checking the corresponding routes.

David Ahern (4):
selftests: fib_tests: simplify ip commands in a namespace
selftests: fib_tests: Make test results more verbose
selftests: fib_tests: Move admin of dummy0 to helpers
selftests: fib_tests: sleep after changing carrier

 tools/testing/selftests/net/fib_tests.sh | 483 +++++++++++++++----------------
 1 file changed, 237 insertions(+), 246 deletions(-)
Signature · 1 line
2.11.0