Skip to content

thunderbolt: Add support for Intel Titan Ridge

Mika Westerberg lkml 3 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest18 patches 1 replyIn review
  2. v218 patches 1 replySuperseded
  3. v118 patches 22 repliesSuperseded

Changes in v3 from the cover letter

- Change wording of the message when Thunderbolt device is rejected by the firmware to be more clear what the reason for the rejection might be. Patches [7/18 and 18/18].
- Use GENMASK() also in ICM_AR_INFO_SLEVEL_MASK in patch [18/18].
- Added Andy's tag to patch [18/18].

Patches in v3 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/18thunderbolt: Resume control channel after hibernation image is createddrivers/thunderbolt/nhi.c+1 -00 replies
2/18thunderbolt: Serialize PCIe tunnel creation with PCI rescandrivers/thunderbolt/switch.c+9 -00 replies
3/18thunderbolt: Handle connecting device in place of host properlydrivers/thunderbolt/icm.c+17 -90 replies
4/18thunderbolt: Do not overwrite error code when domain adding failsdrivers/thunderbolt/nhi.c+1 -10 replies
5/18thunderbolt: Wait a bit longer for root switch config spacedrivers/thunderbolt/icm.c+2 -10 replies
6/18thunderbolt: Wait a bit longer for ICM to authenticate the active NVMdrivers/thunderbolt/icm.c+5 -20 replies
7/18thunderbolt: Handle rejected Thunderbolt devicesdrivers/thunderbolt/icm.c drivers/thunderbolt/tb_msgs.h+7 -00 replies
8/18thunderbolt: Factor common ICM add and update operations outdrivers/thunderbolt/icm.c+87 -490 replies
9/18thunderbolt: Correct function name in kernel-doc commentdrivers/thunderbolt/switch.c+1 -10 replies
10/18thunderbolt: Add tb_switch_get()drivers/thunderbolt/tb.h+7 -00 replies
11/18thunderbolt: Add tb_switch_find_by_route()drivers/thunderbolt/switch.c drivers/thunderbolt/tb.h+34 -00 replies
12/18thunderbolt: Add tb_xdomain_find_by_route()drivers/thunderbolt/xdomain.c include/linux/thunderbolt.h+48 -120 replies
13/18thunderbolt: Add constant for approval timeoutdrivers/thunderbolt/icm.c+3 -20 replies
14/18thunderbolt: Move driver ready handling to struct icmdrivers/thunderbolt/icm.c drivers/thunderbolt/tb_msgs.h+35 -130 replies
15/18thunderbolt: Add 'boot' attribute for devicesDocumentation/ABI/testing/sysfs-bus-thunderbolt drivers/thunderbolt/icm.c drivers/thunderbolt/switch.c +2 more+32 -40 replies
16/18thunderbolt: Add support for preboot ACLDocumentation/ABI/testing/sysfs-bus-thunderbolt drivers/thunderbolt/domain.c drivers/thunderbolt/icm.c +3 more+335 -100 replies
17/18thunderbolt: Introduce USB only (SL4) security levelDocumentation/ABI/testing/sysfs-bus-thunderbolt Documentation/admin-guide/thunderbolt.rst drivers/thunderbolt/domain.c +1 more+23 -60 replies
18/18thunderbolt: Add support for Intel Titan Ridgedrivers/thunderbolt/dma_port.c drivers/thunderbolt/icm.c drivers/thunderbolt/nhi.c +3 more+546 -150 replies

Reviews trailers per patch

All 18 patches have a Reviewed-by or Acked-by.

PatchAndy Shevchenko
1/18R-b
2/18R-b
3/18R-b
4/18R-b
5/18R-b
6/18R-b
7/18R-b
8/18R-b
9/18R-b
10/18R-b
11/18R-b
12/18R-b
13/18R-b
14/18R-b
15/18R-b
16/18R-b
17/18R-b
18/18R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v3 thread

Cover letter [PATCH v3 00/18] thunderbolt: Add support for Intel Titan Ridge

Hi,

This series adds support for Intel Titan Ridge Thunderbolt controller. Titan Ridge is the next generation Thunderbolt 3 controller and successor of Alpine Ridge.

In addition to fixes and Titan Ridge support this series adds following:

- USB only security level (SL4).

- A new attribute for devices telling whether they were connected automatically during boot.

- Preboot ACL allows userspace to specify a list of devices (based on device unique_id) that the firmware automatically connects during boot.

The previous versions of the patch series can be seen here:

v2: https://lwn.net/Articles/748030/
v1: https://www.spinics.net/lists/kernel/msg2721243.html

Changes from v2:

- Change wording of the message when Thunderbolt device is rejected by the firmware to be more clear what the reason for the rejection might be. Patches [7/18 and 18/18].
- Use GENMASK() also in ICM_AR_INFO_SLEVEL_MASK in patch [18/18].
- Added Andy's tag to patch [18/18].

Changes from v1:

- Add stable tag to patch [6/18].
- Use tb_xdomain_get() instead of open coding it in patch [12/18].
- If ->get_boot_acl() fails unlock and goto out immediately (follow more

    standard pattern) in patch [12/18].

- Make newline optional in boot_acl_store() in patch [12/18].
- Update Documentation/admin-guide/thunderbolt.rst to show the new "usbonly" security level in patch [17/18].
- Order DMA ports from 3 to 7 in patch [18/18].
- Use 0xffULL instead in get_parent_route() in patch [18/18].
- Sort Titan Ridge PCI IDs numerically in patch [18/18].
- Use GENMASK() in patch [18/18].
- Added Andy's tag to patches 1-17.

Mika Westerberg (13):
thunderbolt: Resume control channel after hibernation image is created
thunderbolt: Serialize PCIe tunnel creation with PCI rescan
thunderbolt: Handle connecting device in place of host properly
thunderbolt: Do not overwrite error code when domain adding fails
thunderbolt: Wait a bit longer for root switch config space
thunderbolt: Wait a bit longer for ICM to authenticate the active NVM
thunderbolt: Handle rejected Thunderbolt devices
thunderbolt: Factor common ICM add and update operations out
thunderbolt: Add tb_switch_get()
thunderbolt: Add constant for approval timeout
thunderbolt: Move driver ready handling to struct icm
thunderbolt: Add support for preboot ACL
thunderbolt: Introduce USB only (SL4) security level

Radion Mirchevsky (4):
thunderbolt: Correct function name in kernel-doc comment
thunderbolt: Add tb_switch_find_by_route()
thunderbolt: Add tb_xdomain_find_by_route()
thunderbolt: Add support for Intel Titan Ridge

Yehezkel Bernat (1):
thunderbolt: Add 'boot' attribute for devices

 Documentation/ABI/testing/sysfs-bus-thunderbolt |  33 +
 Documentation/admin-guide/thunderbolt.rst       |  15 +-
 drivers/thunderbolt/dma_port.c                  |  28 +-
 drivers/thunderbolt/domain.c                    | 130 +++-
 drivers/thunderbolt/icm.c                       | 761 +++++++++++++++++++++---
 drivers/thunderbolt/nhi.c                       |   5 +-
 drivers/thunderbolt/nhi.h                       |   5 +
 drivers/thunderbolt/switch.c                    |  61 +-
 drivers/thunderbolt/tb.h                        |  14 +
 drivers/thunderbolt/tb_msgs.h                   | 180 +++++-
 drivers/thunderbolt/xdomain.c                   |  47 +-
 include/linux/thunderbolt.h                     |  19 +
 12 files changed, 1183 insertions(+), 115 deletions(-)
Signature · 1 line
2.16.1