firmware: development for v4.17
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v3 Latest20 patches 18 repliesIn review
- v2 posting 2/211 patches 21 repliesSuperseded
- v2 posting 1/211 patches 1 replySuperseded
Patches in v3 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/20 | test_firmware: add simple firmware firmware test librarytools/ tools/ tools/ | +51 | 0 replies | |
| 2/20 | test_firmware: enable custom fallback testing on limited kernel configstools/ tools/ tools/ | +33 | 0 replies | |
| 3/20 | test_firmware: replace syfs fallback check with kconfig_has helpertools/ | +1 | 0 replies | |
| 4/20 | firmware: enable to split firmware_class into separate target filesdrivers/ drivers/ | +1 | 0 replies | |
| 5/20 | firmware: simplify CONFIG_FW_LOADER_USER_HELPER_FALLBACK furtherdrivers/ | +18 | 2 replies | |
| 6/20 | firmware: use helpers for setting up a temporary cache timeoutdrivers/ | +30 | 1 reply | |
| 7/20 | firmware: move loading timeout under struct firmware_fallback_configdrivers/ | +33 | 2 replies | |
| 8/20 | firmware: split firmware fallback functionality into its own filedrivers/ drivers/ drivers/ +3 more | +874 | 0 replies | |
| 9/20 | firmware: move firmware loader into its own directoryMAINTAINERS drivers/ drivers/ +5 more | +18 | 0 replies | |
| 10/20 | firmware: enable run time change of forcing fallback loaderdrivers/ drivers/ drivers/ +1 more | +32 | 0 replies | |
| 11/20 | firmware: enable to force disable the fallback mechanism at run timedrivers/ drivers/ drivers/ | +18 | 2 replies | |
| 12/20 | test_firmware: expand on library with shared helperstools/ tools/ tools/ | +63 | 0 replies | |
| 13/20 | test_firmware: test three firmware kernel configs using a proc knobtools/ tools/ tools/ | +122 | 0 replies | |
| 14/20 | rename: _request_firmware_load() fw_load_sysfs_fallback()Documentation/ drivers/ | +11 | 0 replies | |
| 15/20 | firmware: fix checking for return values for fw_add_devm_name()drivers/ | +9 | 0 replies | |
| 16/20 | firmware: add helper to check to see if fw cache is setupdrivers/ | +12 | 0 replies | |
| 17/20 | test_firmware: modify custom fallback tests to use unique filestools/ tools/ tools/ | +46 | 0 replies | |
| 18/20 | firmware: ensure the firmware cache is not used on incompatible callsdrivers/ | +14 | 0 replies | |
| 19/20 | firmware: add request_firmware_cache() to help with cache on rebootDocumentation/ drivers/ include/ | +41 | 7 replies | |
| 20/20 | mt7601u: use request_firmware_cache() to address cache on rebootdrivers/ | +1 | 1 reply |
Reviews trailers per patch
9 of 20 patches have a Reviewed-by or Acked-by.
| Patch | Kees Cook | Cantabile | Jakub Kicinski |
|---|---|---|---|
| 1/20 | |||
| 2/20 | A-b | ||
| 3/20 | A-b | ||
| 4/20 | |||
| 5/20 | A-b | ||
| 6/20 | A-b | ||
| 7/20 | A-b | ||
| 8/20 | |||
| 9/20 | |||
| 10/20 | A-b | ||
| 11/20 | A-b | ||
| 12/20 | |||
| 13/20 | A-b | ||
| 14/20 | |||
| 15/20 | |||
| 16/20 | |||
| 17/20 | |||
| 18/20 | |||
| 19/20 | |||
| 20/20 | T-b | A-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.
Cover letter [PATCH v3 00/20] firmware: development for v4.17
Greg,
Here's a respin of what I have queued up for v4.17 for the firmware API. It combines the cleanup I've been working on and the addition of the new API call request_firmware_cache() for fixing a corner case suspend issue on some type of cards with an optimization in place where the firmware is *not* needed on reboot.
The cleanup work allows us to test the firmware API with one kernel configuration. I've addressed Kees' feedback on this respin and combined the code into drivers/base/firmware_class/.
I've made one new test_firmware change in consideration for one firmware change, the patch "firmware: ensure the firmware cache is not used on incompatible calls" requires us to modify our tests scripts to use the APIs sanely as well.
I've put up these changes on my git tree, refer to the branch "20180307-firmware-dev-for-v4.17" based on linux-next [0] and the same name based on Linus' tree [1].
Questions, feedback, and specially rants are always welcomed.
[0] https://git.kernel.org/pub/scm/linux/kernel/git/mcgrof/linux-next.git/log/?h=20180307-firmware-dev-for-v4.17
[1] https://git.kernel.org/pub/scm/linux/kernel/git/mcgrof/linux.git/log/?h=20180307-firmware-dev-for-v4.17
Luis R. Rodriguez (20):
test_firmware: add simple firmware firmware test library
test_firmware: enable custom fallback testing on limited kernel
configs
test_firmware: replace syfs fallback check with kconfig_has helper
firmware: enable to split firmware_class into separate target files
firmware: simplify CONFIG_FW_LOADER_USER_HELPER_FALLBACK further
firmware: use helpers for setting up a temporary cache timeout
firmware: move loading timeout under struct firmware_fallback_config
firmware: split firmware fallback functionality into its own file
firmware: move firmware loader into its own directory
firmware: enable run time change of forcing fallback loader
firmware: enable to force disable the fallback mechanism at run time
test_firmware: expand on library with shared helpers
test_firmware: test three firmware kernel configs using a proc knob
rename: _request_firmware_load() fw_load_sysfs_fallback()
firmware: fix checking for return values for fw_add_devm_name()
firmware: add helper to check to see if fw cache is setup
test_firmware: modify custom fallback tests to use unique files
firmware: ensure the firmware cache is not used on incompatible calls
firmware: add request_firmware_cache() to help with cache on reboot
mt7601u: use request_firmware_cache() to address cache on reboot
.../driver-api/firmware/fallback-mechanisms.rst | 2 +-
.../driver-api/firmware/request_firmware.rst | 14 +
MAINTAINERS | 2 +-
drivers/base/Makefile | 2 +-
drivers/base/firmware_loader/Makefile | 7 +
drivers/base/firmware_loader/fallback.c | 674 +++++++++++++++++
drivers/base/firmware_loader/fallback.h | 67 ++
drivers/base/firmware_loader/fallback_table.c | 55 ++
drivers/base/firmware_loader/firmware.h | 115 +++
.../{firmware_class.c => firmware_loader/main.c} | 833 ++-------------------
drivers/net/wireless/mediatek/mt7601u/mcu.c | 2 +-
include/linux/firmware.h | 3 +
kernel/sysctl.c | 11 +
tools/testing/selftests/firmware/Makefile | 2 +-
tools/testing/selftests/firmware/config | 4 +
tools/testing/selftests/firmware/fw_fallback.sh | 65 +-
tools/testing/selftests/firmware/fw_filesystem.sh | 72 +-
tools/testing/selftests/firmware/fw_lib.sh | 194 +++++
tools/testing/selftests/firmware/fw_run_tests.sh | 70 ++
19 files changed, 1332 insertions(+), 862 deletions(-)
create mode 100644 drivers/base/firmware_loader/Makefile
create mode 100644 drivers/base/firmware_loader/fallback.c
create mode 100644 drivers/base/firmware_loader/fallback.h
create mode 100644 drivers/base/firmware_loader/fallback_table.c
create mode 100644 drivers/base/firmware_loader/firmware.h
rename drivers/base/{firmware_class.c => firmware_loader/main.c} (60%)
create mode 100755 tools/testing/selftests/firmware/fw_lib.sh
create mode 100755 tools/testing/selftests/firmware/fw_run_tests.shSignature · 1 line
2.16.2