Skip to content

rework dependency removal (v2)

Pablo Neira Ayuso netfilter-devel 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest6 patches 1 replyIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/6src: pass family to payload_dependency_kill()include/payload.h src/netlink.c src/netlink_delinearize.c +1 more+24 -170 replies
2/6payload: add payload_dependency_release() helper functionsrc/payload.c+13 -90 replies
3/6src: add payload_dependency_exists()include/payload.h src/netlink_delinearize.c src/payload.c+36 -160 replies
4/6src: get rid of __payload_dependency_kill()include/payload.h src/netlink_delinearize.c src/payload.c+9 -180 replies
5/6payload: add payload_may_dependency_kill()src/payload.c+29 -20 replies
6/6netlink_delinearize: add meta_may_dependency_kill()src/netlink_delinearize.c+71 -10 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH nft 0/6] rework dependency removal (v2)

Hi,

This patchset aims to address what Florian reported time ago [1]. This is skipping removal of protocol key payload expressions at network base for the netdev, bridge and inet.

It would better to annotate all redundant expressions and add a later stage, where we can do smarter simplifications by looking globally at what we have, instead of just looking at current protocol key expression and last one that we have annotated in the context structure to perform removals. But I would prefer to have a fix now upstream then look at this larger rework later on since it would require to review a bit of the postprocess code.

The initial 4 patches in this batch are just cleanup/preparation patches for patches 5/6 and 6/6.

There is still a few warning in the tests/py/ infrastructure, some of them I think need to be fixed, and at least one can remain there to remind us that we can do better.

Let me know if you have any concern with this.

Thanks.

[1] https://www.spinics.net/lists/netfilter-devel/msg50078.html

Pablo Neira Ayuso (6):
src: pass family to payload_dependency_kill()
payload: add payload_dependency_release() helper function
src: add payload_dependency_exists()
src: get rid of __payload_dependency_kill()
payload: add payload_may_dependency_kill()
netlink_delinearize: add meta_may_dependency_kill()

 include/payload.h         |   7 +--
 src/netlink.c             |   2 +-
 src/netlink_delinearize.c | 106 +++++++++++++++++++++++++++++++++++++++++-----
 src/payload.c             |  85 ++++++++++++++++++++++++++++---------
 4 files changed, 165 insertions(+), 35 deletions(-)
Signature · 1 line
2.11.0