tools/kvm_stat improvements
Get series with b4
b4 am [email protected]Versions newest first
- v1 Latest6 patches 2 repliesIn review
Changes in v2 from the cover letter
* Patch [1]:
- Switched to single underscore prefixing for "private" methods.
* Patch [4]:
- Renamed methods to "tracepoint_is_child" and "debugfs_is_child" from "trc_is_child" et al.
- Also, moved "child_events" and "pid" from DebugfsProvider and TracepointProvider up to "Provider".
Patches in v1 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/6 | tools/kvm_stat: mark private methods as suchtools/ | +66 | 0 replies | |
| 2/6 | tools/kvm_stat: eliminate extra guest/pid selection dialogtools/ tools/ | +39 | 0 replies | |
| 3/6 | tools/kvm_stat: cache compiled regular expressiontools/ | +11 | 2 replies | |
| 4/6 | tools/kvm_stat: separate drilldown and fields filteringtools/ | +97 | 0 replies | |
| 5/6 | tools/kvm_stat: group child events indented after parenttools/ | +59 | 0 replies | |
| 6/6 | tools/kvm_stat: print 'Total' line for multiple events onlytools/ | +1 | 0 replies |
Reviews trailers per patch
No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.
Cover letter [PATCH 0/6] tools/kvm_stat improvements
Some bugfixes (patches 1&2), simplifications (patch 4), plus rework that lays the basis for introducing a (hopefully) neater drilldown mode in patch 7.
Note that in absence of any knowledge of the interdependencies of the events in debugfs on other platforms like x86, this new 'functionality' was only added for S390 for now. Adding other platforms would be easy enough, though.
Furthermore note that the data passing between Providers and Stats is pretty much at its limit now - if we'd ever wanted to put in more attributes along with the event data passed from Providers to Stats, we should probably switch to passing more involved data structures with indicator flags, etc. Not sure if performance is a concern, but from a coding/maintaining point of view that's something we should consider in that case.
Changes in v2:
* Patch [1]:
- Switched to single underscore prefixing for "private" methods.
* Patch [4]:
- Renamed methods to "tracepoint_is_child" and "debugfs_is_child" from "trc_is_child" et al.
- Also, moved "child_events" and "pid" from DebugfsProvider and TracepointProvider up to "Provider".
---
Stefan Raspl (6):
tools/kvm_stat: mark private methods as such tools/kvm_stat: eliminate extra guest/pid selection dialog tools/kvm_stat: cache compiled regular expression tools/kvm_stat: separate drilldown and fields filtering tools/kvm_stat: group child events indented after parent tools/kvm_stat: print 'Total' line for multiple events only
tools/kvm/kvm_stat/kvm_stat | 435 ++++++++++++++++++++++------------------ tools/kvm/kvm_stat/kvm_stat.txt | 4 +- 2 files changed, 246 insertions(+), 193 deletions(-)
Signature · 1 line
2.13.5