Skip to content

various perl fixes

Ævar Arnfjörð Bjarmason git 3 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest13 patches 1 replyIn review
  2. v213 patches 2 repliesSuperseded
  3. v18 patches 26 repliesSuperseded

Patches in v3 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/13perl: *.pm files should not have the executable bitperl/Git/Mail/Address.pm+0 -00 replies
2/13Git.pm: remove redundant "use strict" from sub-packageperl/Git.pm+0 -10 replies
3/13Git.pm: add the "use warnings" pragmaperl/Git.pm+1 -00 replies
4/13gitweb: hard-depend on the Digest::MD5 5.8 modulegitweb/INSTALL gitweb/gitweb.perl+5 -150 replies
5/13Git.pm: hard-depend on the File::{Temp,Spec} modulesperl/Git.pm+2 -80 replies
6/13git-send-email: unconditionally use Net::{SMTP,Domain}git-send-email.perl+11 -130 replies
7/13perl: update our ancient copy of Error.pmperl/Git/FromCPAN/.gitattributes perl/Git/FromCPAN/Error.pm+256 -410 replies
8/13perl: update our copy of Mail::Addressperl/Git/FromCPAN/Mail/Address.pm+6 -20 replies
9/13perl: move CPAN loader wrappers to another namespacecontrib/examples/git-difftool.perl git-send-email.perl perl/Git.pm +2 more+10 -100 replies
10/13perl: generalize the Git::LoadCPAN facilityperl/Git/LoadCPAN.pm perl/Git/LoadCPAN/Error.pm perl/Git/LoadCPAN/Mail/Address.pm+82 -580 replies
11/13perl: move the perl/Git/FromCPAN tree to perl/FromCPANMakefile perl/FromCPAN/.gitattributes perl/FromCPAN/Error.pm +2 more+5 -30 replies
12/13Makefile: add NO_PERL_CPAN_FALLBACKS knobMakefile+8 -00 replies
13/13perl Git::LoadCPAN: emit better errors under NO_PERL_CPAN_FALLBACKSINSTALL Makefile perl/Git/LoadCPAN.pm+44 -50 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v3 yet.

Read the v3 thread

Cover letter [PATCH v3 00/13] various perl fixes

Same as v2 except rebased on master & a couple of commit message fixes, thanks to Eric Sunshine (thanks!). tbdiff with v2:

4: 0d67af28fb ! 4: 8ad874c944 gitweb: hard-depend on the Digest::MD5 5.8 module
@@ -14,9 +14,6 @@
always be run on at least 5.8, so there's no need to mention Digest::MD5 as a required module in the documentation, let's instead say that we require perl 5.8.
-
- As with the preceding Net::{SMTP,Domain} change we now unconditionally
- "use" the module instead.

1. $ corelist Digest::MD5
Data for 2015-02-14
[...]
6: 92429af3a3 ! 6: 3f44312821 git-send-email: unconditionally use Net::{SMTP,Domain}
@@ -5,7 +5,7 @@
The Net::SMTP and Net::Domain were both first released with perl v5.7.3[1], since my d48b284183 ("perl: bump the required Perl version to 5.8 from 5.6.[21]", 2010-09-24) we've depended on 5.8, so there's
- no reason to conditionally require this anymore.
+ no reason to conditionally require them anymore.

This conditional loading was initially added in 87840620fd ("send-email: only 'require' instead of 'use' Net::SMTP",

Todd Zullinger (1):
Makefile: add NO_PERL_CPAN_FALLBACKS knob

Ævar Arnfjörð Bjarmason (12):
perl: *.pm files should not have the executable bit Git.pm: remove redundant "use strict" from sub-package Git.pm: add the "use warnings" pragma
gitweb: hard-depend on the Digest::MD5 5.8 module Git.pm: hard-depend on the File::{Temp,Spec} modules
git-send-email: unconditionally use Net::{SMTP,Domain}
perl: update our ancient copy of Error.pm
perl: update our copy of Mail::Address
perl: move CPAN loader wrappers to another namespace
perl: generalize the Git::LoadCPAN facility
perl: move the perl/Git/FromCPAN tree to perl/FromCPAN perl Git::LoadCPAN: emit better errors under NO_PERL_CPAN_FALLBACKS

 INSTALL                                 |  11 +-
 Makefile                                |  16 +-
 contrib/examples/git-difftool.perl      |   2 +-
 git-send-email.perl                     |  28 ++-
 gitweb/INSTALL                          |   3 +-
 gitweb/gitweb.perl                      |  17 +-
 perl/FromCPAN/.gitattributes            |   1 +
 perl/{Git => }/FromCPAN/Error.pm        | 296 +++++++++++++++++++++++++++-----
 perl/{Git => }/FromCPAN/Mail/Address.pm |   8 +-
 perl/Git.pm                             |  14 +-
 perl/Git/Error.pm                       |  46 -----
 perl/Git/LoadCPAN.pm                    | 104 +++++++++++
 perl/Git/LoadCPAN/Error.pm              |  10 ++
 perl/Git/LoadCPAN/Mail/Address.pm       |  10 ++
 perl/Git/Mail/Address.pm                |  24 ---
 15 files changed, 432 insertions(+), 158 deletions(-)
 create mode 100644 perl/FromCPAN/.gitattributes
 rename perl/{Git => }/FromCPAN/Error.pm (72%)
 rename perl/{Git => }/FromCPAN/Mail/Address.pm (96%)
 delete mode 100644 perl/Git/Error.pm
 create mode 100644 perl/Git/LoadCPAN.pm
 create mode 100644 perl/Git/LoadCPAN/Error.pm
 create mode 100644 perl/Git/LoadCPAN/Mail/Address.pm
 delete mode 100755 perl/Git/Mail/Address.pm
Signature · 1 line
2.15.1.424.g9478a66081