Skip to content

APEI in_nmi() rework and SDEI wire-up

James Morse kvmarm linux-acpi linux-arm-kernel linux-mm 8 versions – Applied

Status from this message: I applied the Boris' fixups manually which led to a bit of rebasing,

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v8 Latest26 patches 9 repliesApplied
  2. v725 patches 46 repliesSuperseded
  3. v618 patches 22 repliesSuperseded
Earlier versions · 5
VersionPostedPatchesRepliesStatus
v520 patches4 repliesSuperseded
v412 patches3 repliesSuperseded
v312 patches13 repliesSuperseded
v211 patches4 repliesSuperseded
v111 patches21 repliesSuperseded

Patches in v8 Applied

#Subject and filesSizeRepliesApplied
1/26ACPI / APEI: Don't wait to serialise with oops messages when panic()ingdrivers/acpi/apei/ghes.c+0 -20 replies
2/26ACPI / APEI: Remove silent flag from ghes_read_estatus()drivers/acpi/apei/ghes.c+7 -80 replies
3/26ACPI / APEI: Switch estatus pool to use vmalloc memorydrivers/acpi/apei/ghes.c+15 -150 replies
4/26ACPI / APEI: Make hest.c manage the estatus memory pooldrivers/acpi/apei/ghes.c drivers/acpi/apei/hest.c include/acpi/ghes.h+17 -281 reply
5/26ACPI / APEI: Make estatus pool allocation a static sizedrivers/acpi/apei/ghes.c drivers/acpi/apei/hest.c include/acpi/ghes.h+8 -450 replies
6/26ACPI / APEI: Don't store CPER records physical address in struct ghesdrivers/acpi/apei/ghes.c include/acpi/ghes.h+27 -200 replies
7/26ACPI / APEI: Remove spurious GHES_TO_CLEAR checkdrivers/acpi/apei/ghes.c+0 -30 replies
8/26ACPI / APEI: Don't update struct ghes' flags in read/clear estatusdrivers/acpi/apei/ghes.c include/acpi/ghes.h+0 -60 replies
9/26ACPI / APEI: Generalise the estatus queue's notify codedrivers/acpi/apei/ghes.c+43 -221 reply
10/26ACPI / APEI: Don't allow ghes_ack_error() to mask earlier errorsdrivers/acpi/apei/ghes.c+22 -250 replies
11/26ACPI / APEI: Move NOTIFY_SEA between the estatus-queue and NOTIFY_NMIdrivers/acpi/apei/ghes.c+59 -540 replies
12/26ACPI / APEI: Switch NOTIFY_SEA to use the estatus queuedrivers/acpi/apei/Kconfig drivers/acpi/apei/ghes.c+6 -280 replies
13/26KVM: arm/arm64: Add kvm_ras.h to collect kvm specific RAS plumbingarch/arm/include/asm/kvm_ras.h arch/arm/include/asm/system_misc.h arch/arm64/include/asm/kvm_ras.h +3 more+28 -100 replies
14/26arm64: KVM/mm: Move SEA handling behind a single 'claim' interfacearch/arm64/include/asm/acpi.h arch/arm64/include/asm/daifflags.h arch/arm64/include/asm/kvm_ras.h +2 more+55 -210 replies
15/26ACPI / APEI: Move locking to the notification helperdrivers/acpi/apei/ghes.c+25 -90 replies
16/26ACPI / APEI: Let the notification helper specify the fixmap slotdrivers/acpi/apei/ghes.c+39 -530 replies
17/26ACPI / APEI: Pass ghes and estatus separately to avoid a later copydrivers/acpi/apei/ghes.c+49 -430 replies
18/26ACPI / APEI: Make GHES estatus header validation more user friendlydrivers/acpi/apei/ghes.c+32 -141 reply
19/26ACPI / APEI: Split ghes_read_estatus() to allow a peek at the CPER lengthdrivers/acpi/apei/ghes.c+29 -110 replies
20/26ACPI / APEI: Only use queued estatus entry during in_nmi_queue_one_entry()drivers/acpi/apei/ghes.c+37 -270 replies
21/26ACPI / APEI: Use separate fixmap pages for arm64 NMI-like notificationsarch/arm64/include/asm/fixmap.h drivers/acpi/apei/ghes.c+2 -20 replies
22/26mm/memory-failure: Add memory_failure_queue_kick()include/linux/mm.h mm/memory-failure.c+15 -10 replies
23/26ACPI / APEI: Kick the memory_failure() queue for synchronous errorsdrivers/acpi/apei/ghes.c include/acpi/ghes.h+60 -110 replies
24/26arm64: acpi: Make apei_claim_sea() synchronise with APEI's irq workarch/arm64/kernel/acpi.c arch/arm64/mm/fault.c+27 -51 reply
25/26firmware: arm_sdei: Add ACPI GHES registration helperarch/arm64/include/asm/fixmap.h drivers/firmware/arm_sdei.c include/linux/arm_sdei.h+78 -00 replies
26/26ACPI / APEI: Add support for the SDEI GHES Notification typedrivers/acpi/apei/ghes.c include/linux/arm_sdei.h+88 -00 replies

Reviews trailers per patch

16 of 26 patches have a Reviewed-by or Acked-by.

PatchBorislav PetkovPunit AgrawalTyler BaicarMarc ZyngierCatalin MarinasJulien Thierry
1/26A-b
2/26R-b
3/26R-b
4/26R-b
5/26R-b
6/26R-b
7/26R-b
8/26R-b
9/26R-b T-b
10/26
11/26
12/26
13/26R-b T-b A-b A-b
14/26T-b A-b A-b
15/26R-b
16/26R-b
17/26
18/26
19/26
20/26R-b
21/26
22/26
23/26
24/26R-b T-b A-b R-b
25/26A-b
26/26

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 6 reviewers.

Read the v8 thread

Cover letter [PATCH v8 00/26] APEI in_nmi() rework and SDEI wire-up

Changes since v7?
* Removed the memory allocation in the task_work stuff.
* More user-friendly and easier on the eye,
* Switched the irq-mask testing in the arch code to be safe before&after Julien's GIC PMR series.
Specific changes are noted in each patch.

This series aims to wire-up arm64's fancy new software-NMI notifications for firmware-first RAS. These need to use the estatus-queue, which is also needed for notifications via emulated-SError. All of these things take the 'in_nmi()' path through ghes_copy_tofrom_phys(), and so will deadlock if they can interact, which they might.

To that end, this series removes the in_nmi() stuff from ghes.c. Locks are pushed out to the notification helpers, and fixmap entries are passed in to the code that needs them. This means the estatus-queue users can interrupt each other however they like.

While doing this there is a fair amount of cleanup, which is (now) at the beginning of the series. NMIlike notifications interrupting ghes_probe() can go wrong for three different reasons. CPER record blocks greater than PAGE_SIZE dont' work.
The estatus-pool allocation is simplified and the silent-flag/oops-begin is removed.

Nothing in this series is intended as fixes, as its all cleanup or never-worked.

----------%<----------
The earlier boiler-plate:

What's SDEI? Its ARM's "Software Delegated Exception Interface" [0]. It's used by firmware to tell the OS about firmware-first RAS events.

These Software exceptions can interrupt anything, so I describe them as NMI-like. They aren't the only NMI-like way to notify the OS about firmware-first RAS events, the ACPI spec also defines 'NOTFIY_SEA' and 'NOTIFY_SEI'.

(Acronyms: SEA, Synchronous External Abort. The CPU requested some memory, but the owner of that memory said no. These are always synchronous with the instruction that caused them. SEI, System-Error Interrupt, commonly called SError. This is an asynchronous external abort, the memory-owner didn't say no at the right point. Collectively these things are called external-aborts How is firmware involved? It traps these and re-injects them into the kernel once its written the CPER records).

APEI's GHES code only expects one source of NMI. If a platform implements more than one of these mechanisms, APEI needs to handle the interaction. 'SEA' and 'SEI' can interact as 'SEI' is asynchronous. SDEI can interact with itself: its exceptions can be 'normal' or 'critical', and firmware could use both types for RAS. (errors using normal, 'panic-now' using critical).
----------%<----------

This series is base on v5.0-rc1, and can be retrieved from:
git://linux-arm.org/linux-jm.git -b apei_ioremap_rework/v8

Known issues:
* ghes_copy_tofrom_phys() already takes a lock in NMI context, this series moves that around, and makes sure we never try to take the same lock from different NMIlike notifications. Since the switch to queued spinlocks it looks like the kernel can only be 4 context's deep in spinlock, which arm64 could exceed as it doesn't have a single architected NMI. This would be fixed by dropping back to test-and-set when the nesting gets too deep:
lore.kernel.org/r/[email protected]

* Taking an NMI from a KVM guest on arm64 with VHE leaves HCR_EL2.TGE clear, meaning AT and TLBI point at the guest, and PAN/UAO are squiffy. Only TLBI matters for APEI, and this is fixed by Julien's patch:
http://lore.kernel.org/r/[email protected]

* Linux ignores the physical address mask, meaning it doesn't call memory_failure() on all the affected pages if firmware or hypervisor believe in a different page size. Easy to hit on arm64, (easy to fix too, it just conflicts with this series)

[v7] https://lore.kernel.org/linux-arm-kernel/[email protected]/
[v6] https://www.spinics.net/lists/linux-acpi/msg84228.html
[v5] https://www.spinics.net/lists/linux-acpi/msg82993.html
[v4] https://www.spinics.net/lists/arm-kernel/msg653078.html
[v3] https://www.spinics.net/lists/arm-kernel/msg649230.html

[0] https://static.docs.arm.com/den0054/a/ARM_DEN0054A_Software_Delegated_Exception_Interface.pdf

James Morse (26):
ACPI / APEI: Don't wait to serialise with oops messages when
panic()ing
ACPI / APEI: Remove silent flag from ghes_read_estatus() ACPI / APEI: Switch estatus pool to use vmalloc memory ACPI / APEI: Make hest.c manage the estatus memory pool ACPI / APEI: Make estatus pool allocation a static size ACPI / APEI: Don't store CPER records physical address in struct ghes ACPI / APEI: Remove spurious GHES_TO_CLEAR check
ACPI / APEI: Don't update struct ghes' flags in read/clear estatus ACPI / APEI: Generalise the estatus queue's notify code ACPI / APEI: Don't allow ghes_ack_error() to mask earlier errors ACPI / APEI: Move NOTIFY_SEA between the estatus-queue and NOTIFY_NMI ACPI / APEI: Switch NOTIFY_SEA to use the estatus queue
KVM: arm/arm64: Add kvm_ras.h to collect kvm specific RAS plumbing
arm64: KVM/mm: Move SEA handling behind a single 'claim' interface ACPI / APEI: Move locking to the notification helper
ACPI / APEI: Let the notification helper specify the fixmap slot ACPI / APEI: Pass ghes and estatus separately to avoid a later copy ACPI / APEI: Make GHES estatus header validation more user friendly ACPI / APEI: Split ghes_read_estatus() to allow a peek at the CPER
length
ACPI / APEI: Only use queued estatus entry during
in_nmi_queue_one_entry()
ACPI / APEI: Use separate fixmap pages for arm64 NMI-like
notifications
mm/memory-failure: Add memory_failure_queue_kick()
ACPI / APEI: Kick the memory_failure() queue for synchronous errors
arm64: acpi: Make apei_claim_sea() synchronise with APEI's irq work
firmware: arm_sdei: Add ACPI GHES registration helper
ACPI / APEI: Add support for the SDEI GHES Notification type

 arch/arm/include/asm/kvm_ras.h       |  14 +
 arch/arm/include/asm/system_misc.h   |   5 -
 arch/arm64/include/asm/acpi.h        |   4 +-
 arch/arm64/include/asm/daifflags.h   |   1 +
 arch/arm64/include/asm/fixmap.h      |   6 +-
 arch/arm64/include/asm/kvm_ras.h     |  25 +
 arch/arm64/include/asm/system_misc.h |   2 -
 arch/arm64/kernel/acpi.c             |  54 ++
 arch/arm64/mm/fault.c                |  25 +-
 drivers/acpi/apei/Kconfig            |  12 +-
 drivers/acpi/apei/ghes.c             | 725 ++++++++++++++++-----------
 drivers/acpi/apei/hest.c             |  10 +-
 drivers/firmware/arm_sdei.c          |  68 +++
 include/acpi/ghes.h                  |   7 +-
 include/linux/arm_sdei.h             |   9 +
 include/linux/mm.h                   |   1 +
 mm/memory-failure.c                  |  15 +-
 virt/kvm/arm/mmu.c                   |   4 +-
 18 files changed, 646 insertions(+), 341 deletions(-)
 create mode 100644 arch/arm/include/asm/kvm_ras.h
 create mode 100644 arch/arm64/include/asm/kvm_ras.h
Signature · 1 line
2.20.1