Skip to content

netfilter: ipt_CLUSTERIP: two more fixes

Florian Westphal netfilter-devel 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest2 patches 1 replyIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2netfilter: ipt_CLUSTERIP: put config struct if we can't increment ct refcountnet/ipv4/netfilter/ipt_CLUSTERIP.c+6 -20 replies
2/2netfilter: ipt_CLUSTERIP: put config instead of freeing itnet/ipv4/netfilter/ipt_CLUSTERIP.c+4 -30 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH nf 0/2] netfilter: ipt_CLUSTERIP: two more fixes

During code audit I found two more bugs in CLUSTERIP, first one is a refcount leak, second is possible use-after free due to kfree() of rcu-protected (and already visible) structure.

I think its time to remove this target, so, if anyone has a good reason to not nuke it in nf-next please let me know soon.