Skip to content

keymap: support kbd layouts with multiple mappings for the same key.

Gerd Hoffmann qemu-devel 3 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest5 patches 6 repliesIn review
  2. v25 patches 5 repliesSuperseded
  3. v15 patches 0 repliesSuperseded

Patches in v3 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/5keymap: make struct kbd_layout_t private to ui/keymaps.cui/keymaps.c ui/keymaps.h+31 -300 replies
2/5keymap: use glib hash for kbd_layout_tui/keymaps.c ui/trace-events+32 -431 reply
3/5keymap: numpad keysyms and keycodes are fixedui/keymaps.c+9 -520 replies
4/5keymap: record multiple keysym -> keycode mappingsui/keymaps.c+11 -30 replies
5/5keymap: consider modifier state when picking a mappingui/curses.c ui/keymaps.c ui/keymaps.h +2 more+48 -65 replies

Reviews trailers per patch

All 5 patches have a Reviewed-by or Acked-by.

PatchDaniel P. Berrangé
1/5R-b
2/5R-b
3/5R-b
4/5R-b
5/5R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v3 thread

Cover letter [Qemu-devel] [PATCH v3 0/5] keymap: support kbd layouts with multiple mappings for the same key.

The reverse keymap (-k $map) code has problems dealing with keymaps where multiple key combinations can create the same keysym, because it can store a single keycode per keysym only. This series fixes it and does some cleanups along the way.

v2: rebase, codestyle fixes.
v3: use GINT_TO_POINTER

Gerd Hoffmann (5):
keymap: make struct kbd_layout_t private to ui/keymaps.c
keymap: use glib hash for kbd_layout_t
keymap: numpad keysyms and keycodes are fixed
keymap: record multiple keysym -> keycode mappings
keymap: consider modifier state when picking a mapping

 ui/keymaps.h    |  30 +++--------
 ui/curses.c     |   3 +-
 ui/keymaps.c    | 163 +++++++++++++++++++++++++++++---------------------------
 ui/sdl.c        |   6 ++-
 ui/vnc.c        |   9 +++-
 ui/trace-events |   2 +-
 6 files changed, 105 insertions(+), 108 deletions(-)
Signature · 1 line
2.9.3