Skip to content

SMB3.11 preauth integrity

Aurelien Aptel linux-cifs 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest3 patches 1 replyIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/3CIFS: refactor crypto shash/sdesc allocation&freefs/cifs/cifsencrypt.c fs/cifs/cifsproto.h fs/cifs/link.c +3 more+93 -1730 replies
2/3CIFS: add sha512 secmechfs/cifs/Kconfig fs/cifs/cifsencrypt.c fs/cifs/cifsfs.c +3 more+44 -00 replies
3/3CIFS: implement v3.11 preauth integrityfs/cifs/cifsglob.h fs/cifs/smb2misc.c fs/cifs/smb2pdu.c +3 more+112 -21 reply

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH v1 0/3] SMB3.11 preauth integrity

Hi,

This patchset implements pre-authentification signing in which is mandatory in SMB3.11 (packet signing never worked for 3.11 in cifs.ko before this).

The main difference is that the signing key is derived from hashing previous requests and responses. This was partially implemented by Steve some time ago (the preauth hash buffers were already in the server and session structures).

The mechanism is well described in the SMB3.11 presentation given at SDC 2015 (slides are availaible here [1]).

Since this requires a new hashing alg (SHA512) I've tried to clean up some of the crypto code by refactoring shash & sdesc memory management in separate functions. Much more readable now :)

1: https://www.snia.org/sites/default/files/SDC15_presentations/smb/GregKramer_%20SMB_3-1-1_rev.pdf

Aurelien Aptel (3):
CIFS: refactor crypto shash/sdesc allocation&free
CIFS: add sha512 secmech
CIFS: implement v3.11 preauth integrity

 fs/cifs/Kconfig         |  1 +
 fs/cifs/cifsencrypt.c   | 85 +++++++------------------------------------
 fs/cifs/cifsfs.c        |  1 +
 fs/cifs/cifsglob.h      |  7 +++-
 fs/cifs/cifsproto.h     |  5 +++
 fs/cifs/link.c          | 27 +++-----------
 fs/cifs/misc.c          | 54 +++++++++++++++++++++++++++
 fs/cifs/smb2misc.c      | 64 ++++++++++++++++++++++++++++++++
 fs/cifs/smb2pdu.c       | 25 +++++++++++++
 fs/cifs/smb2pdu.h       |  1 +
 fs/cifs/smb2proto.h     |  5 +++
 fs/cifs/smb2transport.c | 97 +++++++++++++++++++++----------------------------
 fs/cifs/smbencrypt.c    | 27 +++-----------
 fs/cifs/transport.c     | 17 +++++++++
 14 files changed, 245 insertions(+), 171 deletions(-)
Signature · 1 line
2.12.3