Skip to content

ASoC: Intel: sst: Fix Bay Trail suspend/resume issues

Hans de Goede lkml 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest9 patches 16 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/9ASoC: Intel: sst: Fix error-code check in sst_pause_stream()sound/soc/intel/atom/sst/sst_stream.c+1 -12 replies
2/9ASoC: Intel: sst: Remove 2 unused members from stream_info structsound/soc/intel/atom/sst/sst.h sound/soc/intel/atom/sst/sst_pvt.c+0 -80 replies
3/9ASoC: Intel: sst: Remove unnecessary sst_init_stream() functionsound/soc/intel/atom/sst/sst.h sound/soc/intel/atom/sst/sst_pvt.c sound/soc/intel/atom/sst/sst_stream.c+2 -120 replies
4/9ASoC: Intel: sst: Remove unused STREAM_DECODE and STREAM_RESET statessound/soc/intel/atom/sst/sst.h sound/soc/intel/atom/sst/sst_drv_interface.c+1 -220 replies
5/9ASoC: Intel: sst: Add sst_realloc_stream() functionsound/soc/intel/atom/sst/sst.h sound/soc/intel/atom/sst/sst_stream.c+56 -350 replies
6/9ASoC: Intel: sst: Free streams on suspend, re-alloc on resumearch/x86/include/asm/platform_sst_audio.h sound/soc/intel/atom/sst/sst.c sound/soc/intel/atom/sst/sst.h +2 more+53 -35 replies
7/9ASoc: rt5651: Fix regcache sync errors on resumesound/soc/codecs/rt5651.c+1 -00 replies
8/9ASoC: Intel: bytcr_rt5640: Drop unwanted ignore_suspend settingssound/soc/intel/boards/bytcr_rt5640.c+0 -48 replies
9/9ASoC: Intel: bytcr_rt5651: Drop unwanted ignore_suspend settingssound/soc/intel/boards/bytcr_rt5651.c+0 -30 replies

Reviews trailers per patch

None of the 9 patches has a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchHans de GoedeAndy Shevchenko
SeriesR-b
1/9
2/9
3/9
4/9
5/9
6/9T-b
7/9
8/9
9/9

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH 0/9] ASoC: Intel: sst: Fix Bay Trail suspend/resume issues

Hi All,

Here is a series fixing suspend/resume errors (and broken audio after resume) on Bay Trail devices.

Cherry Trail devices also do not like being suspend while audio is playing, but with different sypmtoms instead of SST_ERR_INVALID_STREAM_ID errors, if a stream was playing (being allocated is fine, playing is a problem) before suspend then after resume we get the following errors:

  [ 2312.389974] intel_sst_acpi 808622A8:00: sst: Busy wait failed, cant send this msg
  [ 2312.597976] intel_sst_acpi 808622A8:00: sst: Busy wait failed, cant send this msg
  ...

Until the stream is stopped and restarted after which things work fine again. I've tried enabling the quirk this commit adds for Cherry Trail devices too, but that does not help. If anyone has any clues about the CHT problem, please let me know.

Regards,

Hans